2000639 - Remove nsViewManager.

Status: RESOLVED FIXED

(Core :: Web Painting, task)

Description

[Emilio Cobos Álvarez [:emilio]]

After the blocking bugs, it's little more than a backpointer to the pres shell.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2000639 - Remove nsViewManager. r=#layout,tnikkel

After the previous patches, nsViewManager is basically a backpointer to
its pres shell.

Remove it and just make PresShell manage the root view directly. After
this is done, we can decide what to do about nsView (which is itself
little more than a widget listener that forwards to pres shell right
now).

This technically starts listening to mParentWidget slightly later (on
pres shell creation), but I think that's ok.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2000639 - Remove nsIWidget::mUseAttachedEvents. r=tnikkel,#layout

It hasn't done anything useful for a while. The widget listener's shell
and the view's shell will always match for the cases where both exist.

For popups things go through nsMenuPopupFrame::HandleEvent now.

Comment 3

[Phabricator Automation]

Comment on attachment 9527322 [details]
Bug 2000639 - Remove nsIWidget::mUseAttachedEvents. r=tnikkel,#layout

Revision D272975 was moved to bug 2000999. Setting attachment 9527322 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ba0e228d4f7b
https://hg.mozilla.org/integration/autoland/rev/3ca6fff3facd
Remove nsViewManager. r=jwatt

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3ca6fff3facd