2000644 - Introduce a superclass of color picker to prepare for multiple subclasses

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, task)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 2000644 - Introduce a superclass of color picker to prepare for multiple subclasses r=#devtools-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/11f938e4771f
https://hg.mozilla.org/integration/autoland/rev/067e0ef14a2a
Introduce a superclass of color picker to prepare for multiple subclasses r=devtools-reviewers,nchevobbe,desktop-theme-reviewers,frontend-codestyle-reviewers,hjones

Comment 3

[Cristina Horotan [:chorotan]]

Backed out for causing multiple failures

Backout link

Push with failures

Failure log browser_spectrum.js
Failure log browser_datetime_blur.js
Failure log browser_all_files_referenced.js
Failure log test_input_color_input_change_events.html
Failure log wpt

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c7d7e1bba19
https://hg.mozilla.org/integration/autoland/rev/c6c1011f4033
Introduce a superclass of color picker to prepare for multiple subclasses r=devtools-reviewers,nchevobbe,desktop-theme-reviewers,frontend-codestyle-reviewers,hjones

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bb5b4322e10a
https://hg.mozilla.org/integration/autoland/rev/b899327e0ec5
Revert "Bug 2000644 - Introduce a superclass of color picker to prepare for multiple subclasses r=devtools-reviewers,nchevobbe,desktop-theme-reviewers,frontend-codestyle-reviewers,hjones" for causing mochitest failures

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/b899327e0ec53dcd65a41d1a9ddda83a41c1ea95

Push with failures

Failure log -> ERROR - The 'prefs' key must be set in the DEFAULT section of a manifest. Fix the following manifests: dom/html/test/forms/mochitest.toml

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/datetime/browser_datetime_change_event.js | Uncaught exception in test bound test_change_event_simple

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/06041619774f
https://hg.mozilla.org/integration/autoland/rev/6bbfde56da86
Introduce a superclass of color picker to prepare for multiple subclasses r=devtools-reviewers,nchevobbe,desktop-theme-reviewers,frontend-codestyle-reviewers,hjones

Comment 8

[pstanciu]

Backed out for causing wpt failures @color-picker-value.html

• https://hg.mozilla.org/integration/autoland/rev/824b0d14405776c022941a89913413ad4b860864
• WPT failures
• Failure Log

@ input-element-pseudo-open.optional.html

• WPT failures
• Failure Log

@ browser_spectrum.js

• DT failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d2bbd50a6080
https://hg.mozilla.org/integration/autoland/rev/8d9e21bc7833
Introduce a superclass of color picker to prepare for multiple subclasses r=devtools-reviewers,nchevobbe,desktop-theme-reviewers,frontend-codestyle-reviewers,hjones

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/16b534c337a9
https://hg.mozilla.org/integration/autoland/rev/2fe5e0308197
Revert "Bug 2000644 - Introduce a superclass of color picker to prepare for multiple subclasses r=devtools-reviewers,nchevobbe,desktop-theme-reviewers,frontend-codestyle-reviewers,hjones" for causing dt failures @ browser_spectrum.js

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ browser_spectrum.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/2fe5e03081970dfb38767cec028a77156e8d275a

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/shared/test/browser_spectrum.js | New color is correct - Got 128, expected 127

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3c797bb745ce
https://hg.mozilla.org/integration/autoland/rev/d40f2800602e
Introduce a superclass of color picker to prepare for multiple subclasses r=devtools-reviewers,nchevobbe,desktop-theme-reviewers,frontend-codestyle-reviewers,hjones

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d40f2800602e

Comment 14

[Kagami Rosylight [:saschanaz] (they/them)]

🎉