2000677 - Optimize ref tests/casts dominated by other tests/casts

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P2)

Description

[Ben Visness [:bvisness]]

There are optimizations we could perform to tighten up ref.test and ref.cast. For example, a ref.cast dominated by a ref.test of the same type could be omitted.

Comment 1

[Ben Visness [:bvisness]]

Attachment: Bug 2000677: Emit ref.test for ref.is_null. r=rhunt

This allows ref.is_null to participate in other optimizations around
tests and casts.

Comment 2

[Ben Visness [:bvisness]]

Attachment: WIP: Bug 2000677: Make casts congruentTo

I don't think we'll actually do anything with this patch because it
doesn't seem worthwhile to remove redundant casts this way. It should be
covered by other work on this bug.

Comment 3

[Ben Visness [:bvisness]]

Attachment: Bug 2000677: Use GLB instead of LUB in GVN. r=iain

The LUB seemed like the conservative choice when commoning up nodes
during GVN, but actually this is somewhat wrong. Combining the types
from two equivalent nodes is not like combining the types in a phi; in
the latter case the values are not equivalent and therefore you must
find an upper bound, while in the former the values are equivalent and
therefore you can safely take a lower bound.

This restores the property that ref types only lower over the course of
optimization, which makes everything more sane and predictable.

Comment 4

[Ben Visness [:bvisness]]

Attachment: Bug 2000677: Add ref.test/ref.cast optimization pass. r=rhunt,iain

There is a suite of optimizations we can make when ref.test and ref.cast
instructions dominate each other. This is not yet captured by any other
optimizations but should particularly help the pattern of:

local.get $obj
ref.test (ref $t)
if
local.get $obj
ref.cast $obj
...
end

Comment 5

[Ben Visness [:bvisness]]

Attachment: Bug 2000677: Add ion testing utilities. r=rhunt

Adds some utilities for testing the output of wasmDumpIon.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5bdfee067377
https://hg.mozilla.org/integration/autoland/rev/c4763d2128b2
Add ion testing utilities. r=rhunt
https://github.com/mozilla-firefox/firefox/commit/174fda0e59cf
https://hg.mozilla.org/integration/autoland/rev/5c6a5ced3d08
Use GLB instead of LUB in GVN. r=iain
https://github.com/mozilla-firefox/firefox/commit/91b74bbaa75a
https://hg.mozilla.org/integration/autoland/rev/05a6a78965eb
Add ref.test/ref.cast optimization pass. r=rhunt,iain
https://github.com/mozilla-firefox/firefox/commit/48974908c389
https://hg.mozilla.org/integration/autoland/rev/dea2601c7d86
Emit ref.test for ref.is_null. r=rhunt

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c4763d2128b2
https://hg.mozilla.org/mozilla-central/rev/5c6a5ced3d08
https://hg.mozilla.org/mozilla-central/rev/05a6a78965eb
https://hg.mozilla.org/mozilla-central/rev/dea2601c7d86