Open
Bug 2000701
Opened 2 months ago
Updated 1 month ago
The Glean Error Reporting Mechanism doesn't count "ping submitted with invalid reason" as an error
Categories
(Data Platform and Tools :: Glean: SDK, enhancement, P4)
Data Platform and Tools
Glean: SDK
Tracking
(Not tracked)
NEW
People
(Reporter: chutten, Unassigned)
References
Details
If you submit a ping with a value for reason that isn't defined in its definition, the ping is submitted with an empty reason and a warning is logged at ERROR level. And that's it.
This doesn't match the usual Glean Error Reporting Mechanism structure we expect for metrics. In my mind, submitting an undefined reason ought to:
- Record an
invalid_valueerror, with the name of the ping as the label, to be submitted in the (next) offending ping as well as the "health" ping - Communicate any stored errors via
testBeforeNextSubmit/testSubmissionsimilar totest_get_num_recorded_errors/test_get_value(See also bug 1978438)
Point 2 might be too annoying to get quickly done, so I'd accept splitting that off if it proves difficult in the hopes of getting Point 1 landed more quickly so we can have monitoring and documentation.
Updated•1 month ago
|
Priority: -- → P4
You need to log in
before you can comment on or make changes to this bug.
Description
•