2000737 - Simplify freebl.gyp

Status: RESOLVED FIXED

(NSS :: Build, enhancement, P3)

Description

[John Schanck [:jschanck]]

freebl.gyp is too complex. We should refactor it into several gyp files that build smaller static libraries. Let's start by pulling out a GCM library.

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - simplify cross-compilation from build.sh. r=#nss-reviewers

Example usage:
CC=powerpc64le-linux-gnu-gcc CXX=powerpc64le-linux-gnu-g++ ./build.sh -t ppc64le --build-tools-cc=clang

Comment 2

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - separate ppc sha512 library from ppc gcm library. r=#nss-reviewers

Comment 3

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - use hardware x64 GCM in static builds. r=#nss-reviewers

Comment 4

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - create gcm.gyp to simplify freebl.gyp. r=#nss-reviewers

Comment 5

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - fix logic for disabling altivec in gyp builds. r=#nss-reviewers

Comment 6

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - remove unused MP_IS_LITTLE_ENDIAN defines. r=#nss-reviewers

Comment 7

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - avoid mpi dependency in blapii.h. r=#nss-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/7a67fcb48ad8
fix logic for disabling altivec in gyp builds. r=nss-reviewers,nkulatova

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/7b3624db83a1
remove unused MP_IS_LITTLE_ENDIAN defines. r=nss-reviewers,keeler

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/07ddcc93331a
simplify cross-compilation from build.sh. r=nss-reviewers,nkulatova
https://hg.mozilla.org/projects/nss/rev/a8334be4667f
separate ppc sha512 library from ppc gcm library. r=nss-reviewers,nkulatova
https://hg.mozilla.org/projects/nss/rev/5c71d78a242b
use hardware x64 GCM in static builds. r=nss-reviewers,nkulatova

Comment 11

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - fix compilation failure on ia32. r=#nss-reviewers

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/fb4c6085975d
fix compilation failure on ia32. r=nss-reviewers,rrelyea

Comment 13

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - simplify compilation of platform-specific GCM and GHASH. r=#nss-reviewers

Comment 14

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - rename C files for platform-specific ghash implementations. r=#nss-reviewers

Comment 15

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - Darwin compatibility for intel-aes.S and intel-gcm.S. r=#nss-reviewers

Comment 16

[John Schanck [:jschanck]]

Attachment: Bug 2000737 - rename intel-{aes,gcm}.s to .S. r=#nss-reviewers

Comment 17

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/nss/rev/e528f499968a
simplify compilation of platform-specific GCM and GHASH. r=nss-reviewers,keeler
https://hg.mozilla.org/projects/nss/rev/a6c7b50c0b1f
rename C files for platform-specific ghash implementations. r=nss-reviewers,keeler
https://hg.mozilla.org/projects/nss/rev/351b0cdf9b84
rename intel-{aes,gcm}.s to .S. r=nss-reviewers,keeler
https://hg.mozilla.org/projects/nss/rev/c3eaddbd1b12
Darwin compatibility for intel-aes.S and intel-gcm.S. r=nss-reviewers,keeler

Comment 19

[Robert Relyea]

We probably should update all the references in the Makefile from intel-.s to intel-.S just for sanity rather than depend on some automated translation of those in the Makefile.