2000801 - JSON serialization of Chrome Windows is broken

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The current code in Marionette is not able to correctly serialize a ChomeWindow into a WebWindow reference due to the following issue:

• When cloning the ChromeWindow to JSON we assume that each top-level browsing context has a browserId. This doesn't apply for top-level browsing contexts in a ChromeWindow. We need to use the browsing context directly instead.
• All the logic around creating a navigable id for a ChromeWindow and using it later is currently based on the _chromeWindowHandles map from the WindowManager. This is not correct for Marionette because its term of window is the top-level browsing context, but not the window itself. As such we need the logic from the NaviableManager.

I need the correct logic to write proper wdspec tests for bug 1944568.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This is more complicated than I initially thought. While we still have to support unloaded tabs it might be good to keep the browserId as reference for top-level content browsing contexts. But having the chrome browsing context handles in the same map will then cause conflicts because ids are overlapping.

That means when I want to fix the above mentioned issues I need to keep using browserId, but already use the extra chrome id map as backed by the BiMap class as introduced on bug 1944568. I need to do more refactoring to get this finished.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 2000801 - [webdriver-client] Reformat classic client with black.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 2000801 - [webdriver-client] Assert for valid id when creating WebReference instances.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 2000801 - [remote] Add class for bi-directional maps (BiMap).

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 2000801 - [remote] Update Navigable Manager for parent process browsing contexts.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 2000801 - [marionette] Fix JSON serialization and deserialization of chrome windows.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 2000801 - [wdspec] Add Mozilla-specific tests for chrome window handles.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/99ebb5f0a440
https://hg.mozilla.org/integration/autoland/rev/49908c966ae2
[webdriver-client] Reformat classic client with black. r=jgraham,jdescottes
https://github.com/mozilla-firefox/firefox/commit/2633fd83c25f
https://hg.mozilla.org/integration/autoland/rev/253e94b59cdb
[webdriver-client] Assert for valid id when creating WebReference instances. r=jgraham,jdescottes
https://github.com/mozilla-firefox/firefox/commit/a091e7c4c132
https://hg.mozilla.org/integration/autoland/rev/3926b82031cb
[remote] Add class for bi-directional maps (BiMap). r=jdescottes
https://github.com/mozilla-firefox/firefox/commit/5eea86343d63
https://hg.mozilla.org/integration/autoland/rev/1f3ddd9baedb
[remote] Update Navigable Manager for parent process browsing contexts. r=jdescottes
https://github.com/mozilla-firefox/firefox/commit/bac2666086e2
https://hg.mozilla.org/integration/autoland/rev/b29d709c2834
[marionette] Fix JSON serialization and deserialization of chrome windows. r=jdescottes
https://github.com/mozilla-firefox/firefox/commit/6e586279cd09
https://hg.mozilla.org/integration/autoland/rev/49c5526b88eb
[wdspec] Add Mozilla-specific tests for chrome window handles. r=frontend-codestyle-reviewers,jdescottes,mossop

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/49908c966ae2
https://hg.mozilla.org/mozilla-central/rev/253e94b59cdb
https://hg.mozilla.org/mozilla-central/rev/3926b82031cb
https://hg.mozilla.org/mozilla-central/rev/1f3ddd9baedb
https://hg.mozilla.org/mozilla-central/rev/b29d709c2834
https://hg.mozilla.org/mozilla-central/rev/49c5526b88eb

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56408 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot