2000957 - Fluent logspam in testCommonSettingControlPropertiesSet function

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P3)

Description

[Tim Giles [:tgiles]]

When running any preferences test that uses testCommonSettingControlPropertiesSet, Fluent will log the following errors:

• [fluent] Missing message in locale en-US: l10n ID
• [fluent] Couldn't find a message: l10n ID

We should do one of two things:

• Change the mock l10nId to one of the loaded strings in preferences.ftl
• Set up a mock Fluent id like in test_setting_control_extension_controlled

Comment 1

[Dominique]

Attachment: Bug 2000957 - Mocked fluent id in testCommonSettingControlPropertiesSet function to eliminate logspam errors. r?tgiles

Comment 2

[Dominique]

I looked into this bug and pushed my changes into Phabricator. I also ran

./mach test browser/components/preferences/tests/chrome and the errors mentioned are no longer logged.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7de886f333b2
https://hg.mozilla.org/integration/autoland/rev/c9c5a4ddb3c2
Mocked fluent id in testCommonSettingControlPropertiesSet function to eliminate logspam errors. r=tgiles

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c9c5a4ddb3c2