2000975 - getStats should provide outbound-rtp stats immediately on completion of offer/answer

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Byron Campen [:bwc]]

webrtc-pc says: "If selector is an RTCRtpSender, gather stats for and add the following objects to result: All RTCOutboundRtpStreamStats objects representing RTP streams being sent by selector. "

webrtc-stats says: "The RTCOutboundRtpStreamStats is created when the RTP sender is configured by setting a local or remote SDP answer (via setLocalDescription() or setRemoteDescription() and the signaling state returning to "stable")."

These seem to contradict one another; I think the "being sent by" ought to change to something else, perhaps "associated with". The language in webrtc-stats is very clear, while the language in webrtc-pc is not. Plus, it seems that wpt expects the language in webrtc-stats to hold.

Comment 1

[Byron Campen [:bwc]]

See https://github.com/w3c/webrtc-stats/issues/797#issuecomment-2753389360

Comment 2

[Byron Campen [:bwc]]

https://wpt.live/webrtc/rtp-stats-lifetime.https.html?interop-2026

Comment 3

[Byron Campen [:bwc]]

Alright, there is language elsewhere in webrtc-stats that clarifies this:

The RTCOutboundRtpStreamStats is created when the RTP sender is configured by setting a local or remote SDP answer (via setLocalDescription() or setRemoteDescription() and the signaling state returning to "stable").

https://w3c.github.io/webrtc-stats/#the-rtp-statistics-hierarchy

Would be really nice if that were reflected in the language for the stats fields themselves, but at least we have clarity on what to do.

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 2000975 - report outbound-rtp stats in stable;r=dbaker

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ef2936547b97
https://hg.mozilla.org/integration/autoland/rev/dd1650261561
report outbound-rtp stats in stable;r=dbaker,bwc
https://github.com/mozilla-firefox/firefox/commit/e073429f59fe
https://hg.mozilla.org/integration/autoland/rev/12a487ab6379
2019387: apply code formatting via Lando

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dd1650261561
https://hg.mozilla.org/mozilla-central/rev/12a487ab6379

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c58404904231
https://hg.mozilla.org/integration/autoland/rev/4feaec19fca1
Revert "Bug 2000975,Bug 2019387: apply code formatting via Lando" for causing wpt failures at RTCRtpReceiver-video-anyCodec.html

Comment 8

[Silaghi Andreea]

Backed out for causing wpt failures at RTCRtpReceiver-video-anyCodec.html

Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | /webrtc/RTCRtpReceiver-video-anyCodec.html | An RTCRtpReceiver is prepared to receive any negotiated codec. - assert_unreached: Timed out waiting for sent frames Reached unreachable code

Comment 9

[Byron Campen [:bwc]]

I'm not assigned to this anymore, fixing.

Comment 10

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 2000975 - allow fail on flaky WPT RTCRtpReceiver-video-anyCodec;r=bwc

The GMP plugin is being reinitialized for successive resolutions and is seemingly not always able to finish before the timeout.
This patch adds some logging and disables the test on Windows. It is already functionally disabled on Linux and Mac.
Android probably passes because we are not using OpenH264.

See Bug 1952881

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f2f4ccb53409
https://hg.mozilla.org/integration/autoland/rev/95de109770b6
report outbound-rtp stats in stable;r=dbaker,bwc
https://github.com/mozilla-firefox/firefox/commit/d9f4f080d3bd
https://hg.mozilla.org/integration/autoland/rev/a03eb14f5d89
allow fail on flaky WPT RTCRtpReceiver-video-anyCodec;r=bwc
https://github.com/mozilla-firefox/firefox/commit/1135a40ec8d8
https://hg.mozilla.org/integration/autoland/rev/b047b4230c31
2019387: apply code formatting via Lando

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/95de109770b6
https://hg.mozilla.org/mozilla-central/rev/a03eb14f5d89
https://hg.mozilla.org/mozilla-central/rev/b047b4230c31