2000994 - Introduce a common dummy nsIParentChannel type

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

This bug is to generalize the nsIParentChannel implementation used by classes like DataChannelParent and SimpleChannelParent to reduce the amount of boilerplate required to support basic cross-process redirect-supporting channels.

This will be useful to reduce the amount of redundant code required for BlobURL to support cross-process redirects in bug 1619943.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 2000994 - Part 1: Introduce a common base nsIParentChannel type, r=#necko-reviewers

This is a utility type for basic nsIParentChannel implementations which
generally do not care about the full feature set of the nsIParentChannel
interface.

For simple channels which can load entirely within the content process, the
nsIParentChannel instance is only required to complete the redirect hand-off
successfully.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 2000994 - Part 2: Use nsBaseParentChannel for SimpleChannel, r=#necko-reviewers

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 2000994 - Part 3: Use nsBaseParentChannel for nsDataChannel, r=#necko-reviewers

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 2000994 - Part 4: Use nsBaseParentChannel for nsFileChannel, r=#necko-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d50f9cb3f3b1
https://hg.mozilla.org/integration/autoland/rev/07bd1c1884fe
Part 1: Introduce a common base nsIParentChannel type, r=necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/ddcbf623f75c
https://hg.mozilla.org/integration/autoland/rev/8512c684a1d9
Part 2: Use nsBaseParentChannel for SimpleChannel, r=necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/4ff46835ea25
https://hg.mozilla.org/integration/autoland/rev/5f9b640d087f
Part 3: Use nsBaseParentChannel for nsDataChannel, r=necko-reviewers,valentin
https://github.com/mozilla-firefox/firefox/commit/891d40df1dd1
https://hg.mozilla.org/integration/autoland/rev/c79759129e24
Part 4: Use nsBaseParentChannel for nsFileChannel, r=necko-reviewers,valentin

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/07bd1c1884fe
https://hg.mozilla.org/mozilla-central/rev/8512c684a1d9
https://hg.mozilla.org/mozilla-central/rev/5f9b640d087f
https://hg.mozilla.org/mozilla-central/rev/c79759129e24