200118 - Allow Cocoa embedding projects to build in objdir world

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Conrad Carlen (not reading bugmail)]

Since I've become an objdir convert, I need this in order to work on Cocoa
embedding. I've done NSBrowserView.pbproj and will next do CocoaEmbed.pbproj.
The same thing was done as for PPEmbed: In the Makefile, copy the project to the
objdir, and symlink any src dirs.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch to allmakefiles.sh

So Makefiles get generated from the new Makefile.ins

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: patch for embedding/browser/cocoa

Comment 3

[Conrad Carlen (not reading bugmail)]

Attachment: patch for embedding/tests/cocoaEmbed

Comment 4

[Conrad Carlen (not reading bugmail)]

Both of these do the same trick as was done for PPEmbed - the makefile copies
the project to the objdir and makes symlinks to the projects src dirs. Problem
is, that means that the project can't be in the same dir as the src. So, most of
this patch is simply to move the projects. In one case, I was able to just move
it up a  level, for the other, I had to make src and res dirs beside the project.

For cocoaEmbed, more changes were made besides moving things:
(1) I made all of the files which come from dist/Embed be group relative instead
of project relative, recursively. This allows a nice trick for development of
Gecko components. With this setup, I can change only the "Gecko" dir to point to
dist/bin. Then, I can rebuild components and, with no building required from the
PB project, I can run and use the newly built component. This is made possible
by the fact that we use absolute symlinks in dist/bin. It's pure joy.
(2) Removed the call to NS_InitEmbedding() from main.mm. That's called
implicitly by the framework and having it called twice by different libs in the
same process is deadly.

Comment 5

[Conrad Carlen (not reading bugmail)]

Comment on attachment 119121 [details] [diff] [review]
patch to allmakefiles.sh

Looking for r=/sr= on all 3 patches. I'll just ask once here to avoid separate
bugmail for each ;-)

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 119122 [details] [diff] [review]
patch for embedding/browser/cocoa

I'm assuming you have the project files moved to embedding/browser/cocoa in
your tree and it's just not included in this patch.

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 119123 [details] [diff] [review]
patch for embedding/tests/cocoaEmbed

You might want to get the repository files copied for any files that you're
moving.  sr=bryner.

Comment 8

[Conrad Carlen (not reading bugmail)]

> I'm assuming you have the project files moved

Yes, I had not cvs added that. Added now. Thanks.

About copying repository files vs. removing and re-adding, I asked Pink if he
cared about the CVS history for these. He didn't because there's not much too
it. Also, doing it this way, I can do it myself and be done with it. If that's a
CVS no-no, I'll ask leaf to copy files around.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 119121 [details] [diff] [review]
patch to allmakefiles.sh

r=pink.

i've asked conrad to double-check this works for both opt and debug builds,
just to be safe.

Comment 10

[Conrad Carlen (not reading bugmail)]

Forgot to mention - this was checked in on 04/04.