2001388 - Decision tasks should detect changed files without hitting hgmo

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Bastien Orivel [:eijebong]]

It seems to take between 10-15s on decision tasks although we've seen some task take up to 37s. We have all the info we need locally to determine that so let's just use it and save that time.

[task 2025-11-19T21:02:04.143Z] Querying version control for metadata: https://hg.mozilla.org/try/json-pushchangedfiles/a138664c2ed14b4522677f68fa7b822625efb02b
[task 2025-11-19T21:02:04.143Z] attempt 1/10
[task 2025-11-19T21:02:04.143Z] retry: calling get_pushchangedfiles, attempt #1
[task 2025-11-19T21:02:04.144Z] Starting new HTTPS connection (1): hg.mozilla.org:443
[task 2025-11-19T21:02:04.295Z] https://hg.mozilla.org:443 "GET /try/json-pushchangedfiles/a138664c2ed14b4522677f68fa7b822625efb02b HTTP/1.1" 302 0
[task 2025-11-19T21:02:04.296Z] Starting new HTTPS connection (1): hg-edge.mozilla.org:443
[task 2025-11-19T21:02:16.206Z] https://hg-edge.mozilla.org:443 "GET /try/json-pushchangedfiles/a138664c2ed14b4522677f68fa7b822625efb02b HTTP/1.1" 200 None

Comment 1

[Bastien Orivel [:eijebong]]

Attachment: Bug 2001388 - Don't query hg to get a list of changed files in the decision task. r=#releng-reviewers

This should (given very unscientigic observations of a few tasks) save between 10 and 40s on every decision task because hgmo is so slow to respond and we already have the data we need in the checkout to get that list.

The one thing that is worth noting is that we can't just get the files changed for the current push on try because the files changed in that case on the hgmo side was returning all of the files changed since the first non-draft ancestor. Thankfully that was very easy to fix because that is what the get_outgoing_files method returns.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/712692c98db3
https://hg.mozilla.org/integration/autoland/rev/766255748c12
Don't query hg to get a list of changed files in the decision task. r=releng-reviewers,taskgraph-reviewers,ahal

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/766255748c12

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/766255748c12