2001450 - Optimize NimbusGradlePlugin configuration

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, task, P2)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

Nick brought this to my attention after I made some improvements to the glean-gradle-plugin. There's various improvements that can be done here, mostly importantly I think is only downloading and extracting the fml binary once. Right now we download and extract a separate binary and archive for each project, eg:

:fenix:assembleNimbusTools
:components:feature-fxsuggest:assembleNimbusTools
:focus-android:assembleNimbusTools
:components:service-nimbus:assembleNimbusTools	
:components:browser-engine-gecko:assembleNimbusTools

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2001450 - Configuration time optimizations for `NimbusGradlePlugin` r?nalexander

Comment 2

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2001450 - Improve `NimbusGradlePlugin` network I/O with timeouts and connection handling r?nalexander

Comment 3

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2001450 - Centralize `nimbus-fml` archive caching r?nalexander

Comment 4

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2001450 - Add checksum verification and cache validation for downloaded `nimbugs-fml` archives r?nalexander

Comment 5

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 2001450 - Make all projects use a single `assembleNimbusTools` task will only run once at the root level r?nalexander

This ensures that download only runs once, and that the
binary is also only extracted once to a shared location.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aef968f913e5
https://hg.mozilla.org/integration/autoland/rev/228a02eeeb7b
Configuration time optimizations for `NimbusGradlePlugin` r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/74bbf1e7d522
https://hg.mozilla.org/integration/autoland/rev/3f8bbee46542
Improve `NimbusGradlePlugin` network I/O with timeouts and connection handling r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/6e1e4fa31c44
https://hg.mozilla.org/integration/autoland/rev/6aca563a3370
Centralize `nimbus-fml` archive caching r=nalexander,geckoview-reviewers
https://github.com/mozilla-firefox/firefox/commit/6de050c36772
https://hg.mozilla.org/integration/autoland/rev/5a87c2f976c0
Make all projects use a single `assembleNimbusTools` task will only run once at the root level r=nalexander,geckoview-reviewers

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/228a02eeeb7b
https://hg.mozilla.org/mozilla-central/rev/3f8bbee46542
https://hg.mozilla.org/mozilla-central/rev/6aca563a3370
https://hg.mozilla.org/mozilla-central/rev/5a87c2f976c0