Closed Bug 2001526 Opened 4 months ago Closed 2 months ago

Chat Assistant @mentioned rendering

Categories

(Core :: Machine Learning: Frontend, task, P1)

task

Tracking

()

VERIFIED FIXED
149 Branch
Tracking Status
firefox149 --- verified

People

(Reporter: omarg, Assigned: ngrato)

References

(Blocks 1 open bug)

Details

(Whiteboard: [genai][chat])

Attachments

(2 files)

PRD section: https://docs.google.com/document/d/1dbbcvNhI7WRjsmWqHUlO_OZhu7xwYm3pG0KjimNGvbI/edit?tab=t.pynoo4vz6wdz#bookmark=id.naa8t794f0ql

PRD section describes all of @mention functionality, this task is for a component that renders a mention the chat assistant conversation display

Figma: https://www.figma.com/design/5KuePTGmOEUFyCHBHCsGim/AI-Mode-%E2%80%94%C2%A0MVP-Scope-Design?node-id=38-43098&m=dev

Assignee: nobody → ngrato
Severity: -- → N/A
Priority: -- → P1

Creating the contract between the smart input bar mentions and the ai-chat-message mentions. Adding the ability to spot the mentions in the payload and render them out in the DOM.

Pushed by ngrato@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a05b5fb1ada2 https://hg.mozilla.org/integration/autoland/rev/7d4b3df21a89 Chat Assistant @mentioned rendering r=flozia,ai-frontend-reviewers,Gijs,tschuster
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/454b854baa83 https://hg.mozilla.org/integration/autoland/rev/e225d09d402c Revert "Bug 2001526 - Chat Assistant @mentioned rendering r=flozia,ai-frontend-reviewers,Gijs,tschuster" for causing mochitests failures.

Reverted this because it was causing mochitests failures.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: Hit MOZ_CRASH(Page about:aichatcontent must not contain a CSP with the directive img-src that includes page-icon:) at /builds/worker/checkouts/gecko/dom/security/nsContentSecurityUtils.cpp:X
Flags: needinfo?(ngrato)
Pushed by ngrato@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0c4b7bfdf18b https://hg.mozilla.org/integration/autoland/rev/28fa8cd965da Allow the page-icon: protocol by default as a CSP img-src in chrome documents. r=Gijs,simonf
Pushed by ngrato@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6102b3fcbab7 https://hg.mozilla.org/integration/autoland/rev/f61ddd1b4a5d Chat Assistant @mentioned rendering r=flozia,ai-frontend-reviewers,Gijs,tschuster
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d475653aa1f6 https://hg.mozilla.org/integration/autoland/rev/6163aac76c38 Revert "Bug 2001526 - Chat Assistant @mentioned rendering r=flozia,ai-frontend-reviewers,Gijs,tschuster" for causing bc failures @ browser_all_files_referenced.js

Backed out for causing bc failures

Pushed by ngrato@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5cc190f37a14 https://hg.mozilla.org/integration/autoland/rev/f8db0c92eb3b Chat Assistant @mentioned rendering r=flozia,ai-frontend-reviewers,Gijs,tschuster
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
Flags: needinfo?(ngrato)
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49]
Flags: qe-verify+
QA Contact: rdoghi

Verified as fixed in our latest Beta 149.0b1

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49] → [qa-triage-done-c150/b149] [qa-ver-done-c150/b49]
Flags: qe-verify+
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-done-c150/b49] → [qa-triage-done-c150/b149] [qa-ver-done-c150/b149]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: