2001746 - moz-box-group throws an error after clicking on whitespace inside of it then pressing a key

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Mark Striemer [:mstriemer]]

In handleKeydown we attempt to find the current index of the focused element, but if you click on some whitespace within the moz-box-group and press a key, we still get the keypress event, but on the ul we attached our listener to. It doesn't have a position or a parent with a position since it is the container for positioned elements.

STR

1. Render a moz-box-group
2. Click on some whitespace in it (but not text that's part of another child element)
3. Press a key

Expected results: nothing happens
Actual results: JavaScript error: chrome://global/content/elements/moz-box-group.mjs, line 127: TypeError: can't access property "getAttribute", event.target.closest(...) is null

https://searchfox.org/firefox-main/rev/82e2435fd101e64854b8c56ac792c8a5522db4fe/toolkit/content/widgets/moz-box-group/moz-box-group.mjs#127

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 2001746 - Don't throw in moz-box-group on keypresses without a valid focus target r?#recomp-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eaec21428869
https://hg.mozilla.org/integration/autoland/rev/6e7701a430ca
Don't throw in moz-box-group on keypresses without a valid focus target r=akulyk

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6e7701a430ca