Closed Bug 2001778 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 56204 - [Masonry] Update masonry-flow shorthand to grid-lanes-flow

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox147 fixed)

RESOLVED FIXED
147 Branch
Tracking Status
firefox147 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 56204 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/56204
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[Masonry] Update masonry-flow shorthand to grid-lanes-flow

Match the shorthand name to the new display name.

Bug: 343257585
Change-Id: I54a1327cefaed719102e950c28d7b7bae5f381f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7181827
Reviewed-by: Kurt Catti-Schmidt \<kschmi@microsoft.com>
Commit-Queue: Alison Maher \<almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1548246}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 16 tests and 8 subtests

Status Summary

Firefox

OK : 3[GitHub] 16[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
PASS: 7[GitHub] 38[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
FAIL: 40[GitHub] 114[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

OK : 3
PASS: 7
FAIL: 40

Safari

OK : 3
PASS: 7
FAIL: 40

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-direction-computed.html [wpt.fyi]
    • Property masonry-direction value 'row': FAIL
    • Property masonry-direction value 'column': FAIL
    • Property masonry-direction value 'row-reverse': FAIL
    • Property masonry-direction value 'column-reverse': FAIL
  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-direction-valid.html [wpt.fyi]
    • e.style['masonry-direction'] = "row" should set the property value: FAIL
    • e.style['masonry-direction'] = "row-reverse" should set the property value: FAIL
    • e.style['masonry-direction'] = "column" should set the property value: FAIL
    • e.style['masonry-direction'] = "column-reverse" should set the property value: FAIL
  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-fill-computed.html [wpt.fyi]
    • Property masonry-fill value 'normal': FAIL
    • Property masonry-fill value 'reverse': FAIL
  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-fill-valid.html [wpt.fyi]
    • e.style['masonry-fill'] = "normal" should set the property value: FAIL
    • e.style['masonry-fill'] = "reverse" should set the property value: FAIL
  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-flow-computed.html [wpt.fyi]
    • Property grid-lanes-flow value 'column normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property grid-lanes-flow value 'column reverse': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property grid-lanes-flow value 'row normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property grid-lanes-flow value 'row reverse': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property grid-lanes-flow value 'column-reverse normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property grid-lanes-flow value 'column-reverse reverse': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property grid-lanes-flow value 'row-reverse normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property grid-lanes-flow value 'row-reverse reverse': FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-flow-valid.html [wpt.fyi]
    • e.style['grid-lanes-flow'] = "column normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column normal" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column normal" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column normal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column reverse" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column reverse" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column reverse" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row normal" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row normal" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row normal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row reverse" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row reverse" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row reverse" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column-reverse normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column-reverse reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column-reverse normal" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column-reverse normal" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column-reverse normal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column-reverse reverse" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column-reverse reverse" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "column-reverse reverse" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row-reverse normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row-reverse reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row-reverse normal" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row-reverse normal" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row-reverse normal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row-reverse reverse" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row-reverse reverse" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['grid-lanes-flow'] = "row-reverse reverse" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-shorthand-computed.html [wpt.fyi]
    • Property masonry value '"a b" 1fr 2fr row normal': FAIL
    • Property masonry value '8px column normal': FAIL
    • Property masonry value '"a b c" 10% 20% 30% row-reverse': FAIL
    • Property masonry value '"a b" 10px 20px column-reverse reverse': FAIL
    • Property masonry value 'min-content row': FAIL
    • Property masonry value 'repeat(5, auto) reverse': FAIL
  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-shorthand-serialization.html [wpt.fyi]
    • grid-template-rows: none,
      grid-template-columns: none,
      grid-template-areas: none,
      masonry-direction: column,
      masonry-fill: normal should be valid.: FAIL
    • grid-template-rows: 10px,
      grid-template-columns: none,
      grid-template-areas: none,
      masonry-direction: column,
      masonry-fill: reverse should be valid.: FAIL
    • grid-template-rows: 10px 20px,
      grid-template-columns: 10% 20%,
      grid-template-areas: none,
      masonry-direction: row,
      masonry-fill: normal should be valid.: FAIL
    • grid-template-rows: none,
      grid-template-columns: 1fr 1fr 3fr,
      grid-template-areas: "a a b",
      masonry-direction: column,
      masonry-fill: reverse should be valid.: FAIL
    • grid-template-rows: 20% 40%,
      grid-template-columns: none,
      grid-template-areas: "b" "a",
      masonry-direction: row,
      masonry-fill: normal should be valid.: FAIL
    • grid-template-rows: none,
      grid-template-columns: fit-content(calc(0.5em + 10px)),
      grid-template-areas: none,
      masonry-direction: column-reverse,
      masonry-fill: normal should be valid.: FAIL
    • grid-template-rows: 10% 20% 40%,
      grid-template-columns: none,
      grid-template-areas: "a" "b" "c",
      masonry-direction: row-reverse,
      masonry-fill: normal should be valid.: FAIL
  • /css/css-grid/grid-lanes/tentative/parsing/grid-lanes-shorthand-valid.html [wpt.fyi]
    • masonry followed by !important: FAIL
    • e.style['masonry'] = ""a" calc(10px) column-reverse normal" should set the property value: FAIL
    • e.style['masonry'] = "minmax(calc(30% + 40vw), 10px)" should set the property value: FAIL
    • masonry: minmax(10px, 20px) row should be valid.: FAIL
    • masonry: 1px 2px should be valid.: FAIL
    • masonry: "a" 10px reverse should be valid.: FAIL
    • masonry: "a b" 10px 20px row normal should be valid.: FAIL
    • masonry: "a b c" 10% 20% 30% row-reverse should be valid.: FAIL
    • masonry: repeat(5, auto) row reverse should be valid.: FAIL
    • e.style['masonry'] = "none" should set grid-template-areas: FAIL
    • e.style['masonry'] = "none" should set grid-template-columns: FAIL
    • e.style['masonry'] = "none" should set masonry-direction: FAIL
    • e.style['masonry'] = "none" should set masonry-fill: FAIL
    • e.style['masonry'] = "none" should not set unrelated longhands: FAIL
    • e.style['masonry'] = "10px reverse" should set grid-template-areas: FAIL
    • e.style['masonry'] = "10px reverse" should set grid-template-columns: FAIL
    • e.style['masonry'] = "10px reverse" should set masonry-direction: FAIL
    • e.style['masonry'] = "10px reverse" should set masonry-fill: FAIL
    • e.style['masonry'] = "10px reverse" should not set unrelated longhands: FAIL
    • e.style['masonry'] = ""b a" 20% 40% column normal" should set grid-template-areas: FAIL
    • e.style['masonry'] = ""b a" 20% 40% column normal" should set grid-template-columns: FAIL
    • e.style['masonry'] = ""b a" 20% 40% column normal" should set masonry-direction: FAIL
    • e.style['masonry'] = ""b a" 20% 40% column normal" should set masonry-fill: FAIL
    • e.style['masonry'] = ""b a" 20% 40% column normal" should not set unrelated longhands: FAIL
    • e.style['masonry'] = ""b b a" 1fr 2fr 3fr row" should set grid-template-areas: FAIL
    • e.style['masonry'] = ""b b a" 1fr 2fr 3fr row" should set grid-template-rows: FAIL
    • e.style['masonry'] = ""b b a" 1fr 2fr 3fr row" should set masonry-direction: FAIL
    • e.style['masonry'] = ""b b a" 1fr 2fr 3fr row" should set masonry-fill: FAIL
    • e.style['masonry'] = ""b b a" 1fr 2fr 3fr row" should not set unrelated longhands: FAIL
    • e.style['masonry'] = "repeat(2, auto) row-reverse" should set grid-template-areas: FAIL
    • e.style['masonry'] = "repeat(2, auto) row-reverse" should set grid-template-rows: FAIL
    • e.style['masonry'] = "repeat(2, auto) row-reverse" should set masonry-direction: FAIL
    • e.style['masonry'] = "repeat(2, auto) row-reverse" should set masonry-fill: FAIL
    • e.style['masonry'] = "repeat(2, auto) row-reverse" should not set unrelated longhands: FAIL
  • /css/css-grid/grid-lanes/tentative/parsing/item-tolerance-computed.html [wpt.fyi]
    • Property item-tolerance value 'normal': FAIL
    • Property item-tolerance value 'infinite': FAIL
    • Property item-tolerance value '10px': FAIL
    • Property item-tolerance value '20%': FAIL
    • Property item-tolerance value 'calc(20% + 10px)': FAIL
    • Property item-tolerance value 'calc(-0.5em + 10px)': FAIL
    • Property item-tolerance value 'calc(0.5em + 10px)': FAIL
  • /css/css-grid/grid-lanes/tentative/parsing/item-tolerance-valid.html [wpt.fyi]
    • e.style['item-tolerance'] = "normal" should set the property value: FAIL
    • e.style['item-tolerance'] = "infinite" should set the property value: FAIL
    • e.style['item-tolerance'] = "initial" should set the property value: FAIL
    • e.style['item-tolerance'] = "0" should set the property value: FAIL
    • e.style['item-tolerance'] = "1px" should set the property value: FAIL
    • e.style['item-tolerance'] = "calc(2em + 3ex)" should set the property value: FAIL
    • e.style['item-tolerance'] = "4%" should set the property value: FAIL
    • e.style['item-tolerance'] = "5vmin" should set the property value: FAIL
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
You need to log in before you can comment on or make changes to this bug.