2001862 - Fix the debug assertions caused by the test case in bug 2000753

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P2)

Description

[Botond Ballo [:botond]]

The test case in bug 2000753 triggers a variety of debug assertions as well as a release assertion.

The patch in bug 2000753 fixes the release assertion, which is a higher priority fix. This bug tracks fixing the debug assertions as well, and adding the test case as a crashtest.

Comment 1

[Botond Ballo [:botond]]

(The crashtest is being added in bug 2000753 but only run in release mode. In this bug we'll run it in debug mode as well.)

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 2001862 - Relax the assumptions made by SetCurrentActiveScroledRoot(). r=mstange

The code previously assumed that the incoming ASR and the
mContentClipASR must have an ancestor-descendant relationship,
but there are legitimate counterexamples to this.

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 2001862 - Introduce ActiveScrolledRoot::LowestCommonAncestor. r=mstange

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 2001862 - Make WebRenderScrollData building more flexible in the kinds of ASR structures in can handle. r=mstange

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 2001862 - Run the crashtest added in bug 2000753 in debug mode as well. r=mstange

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2f990aab82f1
https://hg.mozilla.org/integration/autoland/rev/bfa563be5a12
Relax the assumptions made by SetCurrentActiveScroledRoot(). r=mstange
https://github.com/mozilla-firefox/firefox/commit/29f0c3cd54d6
https://hg.mozilla.org/integration/autoland/rev/5d09f2119c54
Introduce ActiveScrolledRoot::LowestCommonAncestor. r=mstange
https://github.com/mozilla-firefox/firefox/commit/7c720e00e260
https://hg.mozilla.org/integration/autoland/rev/b3535af70ee8
Make WebRenderScrollData building more flexible in the kinds of ASR structures in can handle. r=mstange
https://github.com/mozilla-firefox/firefox/commit/0e5f63291ee6
https://hg.mozilla.org/integration/autoland/rev/1d04ade82cff
Run the crashtest added in bug 2000753 in debug mode as well. r=layout-reviewers,dholbert

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/bfa563be5a12
https://hg.mozilla.org/mozilla-central/rev/5d09f2119c54
https://hg.mozilla.org/mozilla-central/rev/b3535af70ee8
https://hg.mozilla.org/mozilla-central/rev/1d04ade82cff