2001959 - Compile with minor Android 16 versions SDK.

Status: RESOLVED FIXED

(Firefox for Android :: Tooling, task)

Description

[Mihai Adrian Carare [:mcarare]]

https://developer.android.com/about/versions/16/qpr2/setup-sdk

Comment 1

[Ryan VanderMeulen [:RyanVM]]

FYI, I looked at this a couple months ago and have a mostly-working patch. The main issue is that our wrench tests use the cargo-apk library which doesn't support finding non-integer SDK paths. That library is also not very well-maintained at this point, though I did file an upstream issue about it. If this starts blocking things, we'll probably need to hack around it in the fork we're currently using.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

...and then I realized that we can easily work around that by just keeping platform-36 in our SDK repack for the wrench jobs to keep using. A bit of a footgun for future updates, but it'll get the job done until there's an upstream update to handle things more gracefully.

Green on Try: https://treeherder.mozilla.org/jobs?repo=try&revision=1e5473afc2c4cf9c3050813a9e23804973c98a95

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2001959 - Compile with Android SDK 36.1.

Android wrench tests depend on cargo-apk, which doesn't support non-integer platform versions.
Keep the last major version around in android-packages.txt for it to use instead.
https://github.com/rust-mobile/cargo-apk/issues/74

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Tooling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a0d7ad313f50
https://hg.mozilla.org/integration/autoland/rev/53213ad2e919
Compile with Android SDK 36.1. r=jgraham,geckoview-reviewers,android-reviewers,firefox-build-system-reviewers,mcarare,ahochheiden,ohall

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/56405 for changes under testing/web-platform/tests

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/53213ad2e919

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot