2002026 - Use HTML5 forms API to prevent submitting the uplift form when it's incomplete

Status: RESOLVED FIXED

(Conduit :: Lando, defect, P3)

Description

[Paul Adenot (:padenot)]

Required fields should be marked as such in the markup, to prevent accidentally submitting the form only to see an error message, and having to re-type the messages.

Comment 1

[Connor Sheehan [:sheehan]]

Taking a closer look it appears the required attribute is set on all the fields except two:

• the repository selection, as Django forms doesn't support required on CheckboxSelectMultiple widgets: "the checkboxes won’t include the required HTML attribute if the field is required because browser validation would require all checkboxes to be checked instead of at least one."
• the "steps to reproduce for manual QE testing", as that field is only required when "Needs manual QE testing" is true.

We'll have to solve this with Javascript on the client side for these two cases.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] uplift: prevent submitting uplift form when incomplete (Bug 2002026) (#983)

Comment 3

[BMO Github Automation]

Authored by https://github.com/cgsheeh
https://github.com/mozilla-conduit/lando/commit/e0566ab4d9e346c3a8050fe1b5d3df8539ab250c
[main] uplift: prevent submitting uplift form when incomplete (Bug 2002026) r=shtrom