2002035 - The performance impact of MustBeConsumedMicroTask is too high

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Added in Bug 1990842 for safety, unfortunately the performance impact of this class is way too high, and ultimately eats all the performance benefits that the JS Microtask queue adds

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 2002035 - Remove unnecessary barriers in MustConsumeMicroTaskRunnable r?jonco

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/120f48b68486
https://hg.mozilla.org/integration/autoland/rev/67307b22e89b
Remove unnecessary barriers in MustConsumeMicroTaskRunnable r=jonco

Comment 3

[Atila Butkovits]

Backed out for causing xpc failures at test_promise_job_across_sandbox.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/fca2f5e043d75fca3c591850e7822510fd6f1b5d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b3b781fc45ba215f17c601666ab03f3a3b76d1f9&selectedTaskRun=YjGfiVt_SnWCHKuo83khuw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=537842962&repo=autoland&task=YjGfiVt_SnWCHKuo83khuw.0&lineNumber=2679

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/06166ae6872b
https://hg.mozilla.org/integration/autoland/rev/8013cae8d375
Remove unnecessary barriers in MustConsumeMicroTaskRunnable r=jonco

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8013cae8d375