Closed Bug 2002119 (rustc-1.92) Opened 8 months ago Closed 2 months ago

Update builders to rustc 1.92

Categories

(Firefox Build System :: Toolchains, task)

task

Tracking

(firefox153 fixed)

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(1 file)

Release date: December 11.

Depends on: 2002136
Depends on: 2039421
Depends on: 2039447
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Pushed by mh@glandium.org: https://github.com/mozilla-firefox/firefox/commit/4a522cf81ba9 https://hg.mozilla.org/integration/autoland/rev/6dc6e42da4fe Update builders to rustc 1.92. r=firefox-build-system-reviewers,sergesanspaille
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/235db078ed72 https://hg.mozilla.org/integration/autoland/rev/4ce2ecc8a8df Revert "Bug 2002119, Bug 1954004, Bug 1995665 - Update builders to rustc 1.92. r=firefox-build-system-reviewers,sergesanspaille" for causing build bustages in LoadedScript.h.

Reverted this because it was causing build bustages in LoadedScript.h.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/js/loader/LoadedScript.h:706:3: error: virtual method 'DeleteCycleCollectable' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier]
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org: https://github.com/mozilla-firefox/firefox/commit/2e008266d629 https://hg.mozilla.org/integration/autoland/rev/3c95b89a296d Update builders to rustc 1.92. r=firefox-build-system-reviewers,sergesanspaille
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c0adc076e3e2 https://hg.mozilla.org/integration/autoland/rev/c0aa58cf701d Revert "Bug 2002119 - Update builders to rustc 1.92. r=firefox-build-system-reviewers,sergesanspaille" for getting merge conflicts with Bug 1954004, Bug 1995665 for causing wd leackcheck failures
Flags: needinfo?(mh+mozilla)
Depends on: 2040838
Pushed by mh@glandium.org: https://github.com/mozilla-firefox/firefox/commit/73b389c7c952 https://hg.mozilla.org/integration/autoland/rev/8b5c3ef94c5e Update builders to rustc 1.92. r=firefox-build-system-reviewers,sergesanspaille
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Flags: needinfo?(mh+mozilla)

(In reply to Pulsebot from comment #8)

Pushed by mh@glandium.org:
https://github.com/mozilla-firefox/firefox/commit/73b389c7c952
https://hg.mozilla.org/integration/autoland/rev/8b5c3ef94c5e
Update builders to rustc 1.92.
r=firefox-build-system-reviewers,sergesanspaille

Perfherder has detected a talos performance change from push 8b5c3ef94c5ecce150e337ac7a24b8245cf07c42.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
5% perf_reftest_singletons link-style-cache-1.html (doc) windows11-64-24h2-shippable e10s fission stylo webrender 39.84 ms -> 37.75 ms

Need Help or Information?

If you have any questions, please reach out to bacasandrei@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: