Closed Bug 2002190 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 56251 - Fix sorting issue with import map scopes

Categories

(Core :: JavaScript Engine, task, P4)

task

Tracking

()

RESOLVED FIXED
147 Branch
Tracking Status
firefox147 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 56251 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/56251
Details from upstream follow.

Yoav Weiss <yoavweiss@chromium.org> wrote:

Fix sorting issue with import map scopes

This CL fixes the iteration order of ImportMap::scopes_map_,
which should use scopes_vector_ (sorted by keys as specified).

Change-Id: I6b177b01dfa9f4ad66ff7432f3380a0eb87497eb
Bug: 433490539, 406357273, 453147451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7117300
Reviewed-by: Hiroshige Hayashizaki \<hiroshige@chromium.org>
Commit-Queue: Yoav Weiss (@Shopify) \<yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1549571}

Component: web-platform-tests → JavaScript Engine
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests and 25 subtests

Status Summary

Firefox

OK : 11
PASS: 239

Chrome

OK : 11
PASS: 237
FAIL: 2

Safari

OK : 11
PASS: 235
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
You need to log in before you can comment on or make changes to this bug.