Closed Bug 2002253 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 56259 - Fix crash when two identical stylesheets don't produce RuleSets

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
147 Branch
Tracking Status
firefox147 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 56259 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/56259
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

Fix crash when two identical stylesheets don't produce RuleSets

This is a regression from CL:7185810: I forgot that StyleEngine::
RuleSetForSheet can return nullptr if the associated "media" attribute
doesn't match.

Fixed: 463405540
Change-Id: I836ad560038918d8aefb20c512ca535420ddf39c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7203284
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Reviewed-by: Steinar H Gunderson \<sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1549691}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/725e6229c6e6 https://hg.mozilla.org/integration/autoland/rev/70b4f5a9cbd6 [wpt PR 56259] - Fix crash when two identical stylesheets don't produce RuleSets, a=testonly
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
You need to log in before you can comment on or make changes to this bug.