2002257 - Enable renaming download from the Downloads screen

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, enhancement)

Description

[Titouan Thibaud [:titouan]]

In the Downloads screen, add a new option "Rename" on the three-dot-menu for each download.

When the user clicks "Rename", a Dialog opens, pre-filled with the current name.
The part before the extension should be selected (to be clearer, the selection should exclude .jpg´ in the case of image.jpg` for example), and the extension shouldn't be editable. (We will allow extension edition in Bug 2002331).
We can use this Figma that shows how the extension should look like.

The Save button should be disabled if:

• the file name contains only an extension
• the file name is identical to the original name

Make sure that opening the file from the Downloads screen after renaming it works correctly.

Comment 1

[Cathy Lu [:calu]]

We will create the dialogue for renaming from the downloads screen in Bug 2010124 that should come prior.

Comment 2

[Cathy Lu [:calu]]

Attachment: Bug 2002257 - Enable renaming download files

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4c4daec9a8a
https://hg.mozilla.org/integration/autoland/rev/ceb4f36f2e12
Enable renaming download files r=android-reviewers,android-l10n-reviewers,flod,tthibaud

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ceb4f36f2e12

Comment 5

[Mira Lobontiu (Android QA)]

Attachment: 2002257.png

This is not implemented on the Firefox for Android Nightly build from 2/19.
Tested with a Samsung Galaxy s24 (Android 16).
Titouan, could you take a look, please?

Comment 6

[Titouan Thibaud [:titouan]]

Hey Mira,
I think there's some confusion here. Bug 2002273 is the one where we'll let the user chose the name of the download they trigger.

This bug is specifically related to renaming a file that was already downloaded, from the Downloads screen.

The STR is:

• Download a file
• Open the Downloads screen
• Click the ... button on the file you downloaded
• Change the file name

Expected result:

• The new name should be applied to the download in the Download screen, and this should be verifiable from the android file explorer.

Does it make sense? 
Feel free to reach out if anything is unclear.

Comment 7

[Mira Lobontiu (Android QA)]

Oh, yes, sorry, I misunderstood the enhancement.
Verified as implemented and functional on the Firefox for Android Nightly build from 2/19 with a Samsung Galaxy S24 (Android 16), and a Motorola Moto G30 (Android 12).