[wpt-sync] Sync PR 56261 - Fix up scope ordering with multiple import maps
Categories
(Core :: JavaScript Engine, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox147 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 56261 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/56261
Details from upstream follow.
Yoav Weiss <yoavweiss@chromium.org> wrote:
Fix up scope ordering with multiple import maps
As a follow up from https://chromium-review.googlesource.com/c/chromium/src/+/7117300
this CL fixes the ordering of scopes when multiple import maps are
involved. It does that by ensuring that scopes_vector_ is sorted after
a merge.Bug: 433490539, 406357273, 453147451
Change-Id: I80a3bfacbbf3eebe34e392215f85d4869bb8ea8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201449
Reviewed-by: Kouhei Ueno \<kouhei@chromium.org>
Commit-Queue: Yoav Weiss (@Shopify) \<yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1549715}
| Assignee | ||
Updated•1 year ago
|
| Assignee | ||
Comment 1•1 year ago
|
||
| Assignee | ||
Comment 2•1 year ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 1 subtests
Status Summary
Firefox
OK : 2
PASS: 1
FAIL: 1
Chrome
OK : 2
PASS: 1
FAIL: 1
Safari
OK : 2
PASS: 1
FAIL: 1
Links
Details
New Tests That Don't Pass
- /import-maps/multiple-import-maps/scope-ordering.html [wpt.fyi]
- More specific scope from second import map should be checked first:
FAIL(Chrome:FAIL, Safari:PASS)
- More specific scope from second import map should be checked first:
Comment 4•11 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2956fd9ff469
https://hg.mozilla.org/mozilla-central/rev/b1307bfeb594
Description
•