2002342 - Reduce CanvasTranslator data shmem copies

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 2002342 - Reduce CanvasTranslator data shmem copies. r?aosmond

CanvasChild often creates data shmem transfers for snapshots, which CanvasTranslator
immediately copies into a separate memory buffer as soon as it receives the shmem.

Like CanvasChild, we can keep alive these shmems on the CanvasTranslator side for
a reasonable lifetime to directly use the shmem's memory rather than copy from it,
avoiding the sometimes large costs of the copy.

Unlike CanvasChild, this limits the amount of shmems on the CanvasTranslator side
by a pref beyond which the shmems are still copied to a memory buffer as usual.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/43ae770183e0
https://hg.mozilla.org/integration/autoland/rev/20a9530522fd
Reduce CanvasTranslator data shmem copies. r=aosmond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3bf86e525eff
https://hg.mozilla.org/integration/autoland/rev/3d350fd70c36
Revert "Bug 2002342 - Reduce CanvasTranslator data shmem copies. r=aosmond" for causing failures at test_animSVGImage.html.

Comment 4

[Atila Butkovits]

Backed out for causing failures at test_animSVGImage.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/3d350fd70c367962cc6977f1dbd0da392db2a546

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=Ds_boxVRQneLpwYbAvR6Vw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=20a9530522fd19c8fe9c517482d1e5b705c2f98e

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=537444468&repo=autoland&task=Ds_boxVRQneLpwYbAvR6Vw.0&lineNumber=9882
https://treeherder.mozilla.org/logviewer?job_id=537447547&repo=autoland&task=IFAbzeQSQ_iWdd7i0ceKAQ.1&lineNumber=4965
https://treeherder.mozilla.org/logviewer?job_id=537448661&repo=autoland&task=Si1Vk9GOT-2-PVPEuhiXfw.0&lineNumber=10145

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8248df5323d4
https://hg.mozilla.org/integration/autoland/rev/826648a89e46
Reduce CanvasTranslator data shmem copies. r=aosmond

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/826648a89e46