2002635 - Unship asm.js

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Ryan Hunt [:rhunt]]

Placeholder bug for unshipping the asm.js optimizing pipeline. This would disable asm.js specific optimizations, while still keeping asm.js working using the existing JS JITs.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 2002635 - Revert "Bug 1980396: Add javascript.options.asmjs feature to Nimbus feature manifest." r?denispal

This reverts commit b1053297d5300a282d868a638d12dafabb54cf3b.

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 2002635 - Revert "Bug 1980396: Add a new probe that records 5 minutes of JS activity for documents with asm.js." r?smaug

This reverts commit 90af3b6a63d9035d59e2f818bdd2fdc2ab84f6fa.

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 2002635 - Move asm.js deprecation warning into parsing so it always fires. r?arai

Right now we only warn if we successfully compile the asm.js code. Once
we have disabled asm.js optimizations, it would still be good to warn
users that they should migrate to wasm.

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: Bug 2002635 - Disable asm.js. r?bvisness

The shell uses a different --no-asmjs flag, and will continue to have asm.js
enabled for testing purposes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/485d9c1f0171
https://hg.mozilla.org/integration/autoland/rev/8c93fbdbe1a7
Revert "Bug 1980396: Add javascript.options.asmjs feature to Nimbus feature manifest." r=denispal
https://github.com/mozilla-firefox/firefox/commit/1ef03f99181a
https://hg.mozilla.org/integration/autoland/rev/bbf043e49040
Revert "Bug 1980396: Add a new probe that records 5 minutes of JS activity for documents with asm.js." r=smaug
https://github.com/mozilla-firefox/firefox/commit/502003fa685f
https://hg.mozilla.org/integration/autoland/rev/48b80e7d0b74
Move asm.js deprecation warning into parsing so it always fires. r=arai
https://github.com/mozilla-firefox/firefox/commit/415f58c3f99a
https://hg.mozilla.org/integration/autoland/rev/ef549c50d319
Disable asm.js. r=bvisness

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/679bcbcb587b
https://hg.mozilla.org/integration/autoland/rev/be8a4e9f8206
Revert "Bug 2002635 - Disable asm.js. r=bvisness" for causing dt failures @ browser_dbg-features-asm.js

Comment 7

[amarc]

Backed out for causing dt failures

• Backout link
• Push with failures
• Failure Log

Comment 8

[Ryan Hunt [:rhunt]]

A devtools test assumes asm.js is enabled. We can workaround it by enabling the pref for that test.

Comment 9

[Ryan Hunt [:rhunt]]

Attachment: Bug 2002635 - Enable asm.js for devtools test. r?#devtools-reviewers

asm.js is disabled by default now, re-enable it for this test
that requires it to be enabled. Once we remove support for
asm.js we can remove the test.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e4440d8be8ef
https://hg.mozilla.org/integration/autoland/rev/4d597774012d
Revert "Bug 1980396: Add javascript.options.asmjs feature to Nimbus feature manifest." r=denispal
https://github.com/mozilla-firefox/firefox/commit/85f3111cc201
https://hg.mozilla.org/integration/autoland/rev/1b58cf94bada
Revert "Bug 1980396: Add a new probe that records 5 minutes of JS activity for documents with asm.js." r=smaug
https://github.com/mozilla-firefox/firefox/commit/0db3a0b21063
https://hg.mozilla.org/integration/autoland/rev/3a82dd47cf8b
Move asm.js deprecation warning into parsing so it always fires. r=arai
https://github.com/mozilla-firefox/firefox/commit/7055f54278ad
https://hg.mozilla.org/integration/autoland/rev/ebc1884c3a73
Disable asm.js. r=bvisness
https://github.com/mozilla-firefox/firefox/commit/c7522083b358
https://hg.mozilla.org/integration/autoland/rev/5bec6eddfbe9
Enable asm.js for devtools test. r=devtools-reviewers,ochameau

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7f1600615e46
https://hg.mozilla.org/integration/autoland/rev/40f1d088c38c
Revert "Bug 2002635 - Enable asm.js for devtools test. r=devtools-reviewers,ochameau" for causing dt failures @browser_dbg-expressions-error.js.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9bde42d9b33a
https://hg.mozilla.org/integration/autoland/rev/4fc6d76b52a7
Revert "Bug 1980396: Add javascript.options.asmjs feature to Nimbus feature manifest." r=denispal
https://github.com/mozilla-firefox/firefox/commit/5fd4b324f557
https://hg.mozilla.org/integration/autoland/rev/d3e84da3b331
Revert "Bug 1980396: Add a new probe that records 5 minutes of JS activity for documents with asm.js." r=smaug
https://github.com/mozilla-firefox/firefox/commit/7031c812f30f
https://hg.mozilla.org/integration/autoland/rev/54b838317726
Move asm.js deprecation warning into parsing so it always fires. r=arai
https://github.com/mozilla-firefox/firefox/commit/0a27764a77ad
https://hg.mozilla.org/integration/autoland/rev/b3577ce67aec
Disable asm.js. r=bvisness
https://github.com/mozilla-firefox/firefox/commit/ba991052939d
https://hg.mozilla.org/integration/autoland/rev/0c56dd09060d
Enable asm.js for devtools test. r=devtools-reviewers,ochameau

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4fc6d76b52a7
https://hg.mozilla.org/mozilla-central/rev/d3e84da3b331
https://hg.mozilla.org/mozilla-central/rev/54b838317726
https://hg.mozilla.org/mozilla-central/rev/b3577ce67aec
https://hg.mozilla.org/mozilla-central/rev/0c56dd09060d

Comment 14

[Mayank Bansal]

expected 30% regression on Octane-zlib