2002681 - emit step timings as perfherder metrics

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement, P2)

Description

[[e-mail] (:bhearsum)]

We have an ongoing effort to improve try push turnaround times. One area where we have a blind spot at the moment is the breakdown of time spent on different parts of tasks. For the majority of the tasks that we care about (builds and tests), having timings for the different mozharness steps they run would be a sufficient starting point. In particular, this would let us see how much time is spent in set-up vs. actually making builds or running tests.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 2002681: refactor mozharness action skipping r?#releng-reviewers!

This paves the way for recording how long each action takes, while allowing us to easily ignore skipped actions.

This causes no change in behaviour as there's only one caller of run_action, and the logic being moved now runs directly before the call.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: Bug 2002681: ensure `UPLOAD_DIR` is set for mozharness tests r?#releng-reviewers!

This gives us a consistent environment variable to look for to find the right place to put artifacts. This will make a subsequent patch that is writing a perfherder artifact deep in the bowels of mozharness to easily write to the correct place.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: Bug 2002681: recorded timings of mozharness actions in perfherder artifact r?#releng-reviewers!

We have an ongoing effort to improve try push turnaround times. One area where we have a blind spot at the moment is the breakdown of time spent on different parts of tasks. For the majority of the tasks that we care about (builds and tests), having timings for the different mozharness steps they run would be a sufficient starting point. In particular, this would let us see how much time is spent in set-up vs. actually making builds or running tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8dde5c06b580
https://hg.mozilla.org/integration/autoland/rev/74bc0a0b7c9d
refactor mozharness action skipping r=releng-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/40813494e727
https://hg.mozilla.org/integration/autoland/rev/1d4faf6cd8a4
ensure `UPLOAD_DIR` is set for mozharness tests r=releng-reviewers,taskgraph-reviewers,ahal
https://github.com/mozilla-firefox/firefox/commit/095424a9b515
https://hg.mozilla.org/integration/autoland/rev/29456c2b1c0e
recorded timings of mozharness actions in perfherder artifact r=releng-reviewers,jcristau

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/74bc0a0b7c9d
https://hg.mozilla.org/mozilla-central/rev/1d4faf6cd8a4
https://hg.mozilla.org/mozilla-central/rev/29456c2b1c0e