2002728 - Can't take a memory snapshot on Fenix

Status: RESOLVED FIXED

(DevTools :: Memory, defect)

Description

[Alexandre Poirot [:ochameau]]

You would get the following exception when trying to take a memory snapshot from the memory panel while debugging any fenix's tab:

Error: Protocol error (Error): ChromeUtils.importESModule: global option is required in DevTools distinct global from: server0.conn0.heapSnapshotFileActor4 (resource://devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js:1:40)
Stack: onPacket/<@resource://devtools/shared/protocol/Front.js:404:31
DevTools RDP*request@resource://devtools/shared/protocol/Front.js:320:14
generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:57:19
transferHeapSnapshot@resource://devtools/client/fronts/memory.js:77:45
Line: 404, column: 31

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

I'm getting the correct location: ChromeUtils.importESModule: global option is required in DevTools distinct global from: server0.conn0.heapSnapshotFileActor4 (resource://devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js:26:13) which points to https://searchfox.org/firefox-main/rev/f81fae7890605739dd8dde14755f159fe6beb8aa/devtools/shared/heapsnapshot/HeapSnapshotFileUtils.js#26-28

ChromeUtils.defineESModuleGetters(lazy, {
  FileUtils: "resource://gre/modules/FileUtils.sys.mjs",
});

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 2002728 - [devtools] Ensure passing an explicit module context for memory module. r=#devtools

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b07347e94d08
https://hg.mozilla.org/integration/autoland/rev/7459f7aee615
[devtools] Ensure passing an explicit module context for memory module. r=devtools-reviewers,nchevobbe

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7459f7aee615