Closed Bug 2002831 Opened 7 days ago Closed 2 days ago

The "Learn more" link on site permissions prompt is not functioning

Categories

(Firefox for Android :: Settings, defect)

All
Android
defect

Tracking

()

RESOLVED FIXED
147 Branch
Tracking Status
firefox145 --- unaffected
firefox146 --- unaffected
firefox147 + fixed

People

(Reporter: apetridean, Assigned: segun)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fxdroid] [group1])

Attachments

(3 files)

Preconditions

In secret settings, enable LNA blocking.
​- ​Go to "Local Network devices" and select "Ask to allow".

​Run a local web server on your machine (IP: 192.*).
​- On Android (Fenix) in the same network, open: https://lna-testing.notyetsecure.com/
​- Modify fetch() in index.html to use your local server IP: fetch('http://192.168.x.x:8080/index.html')

​In Fenix, set in about:config:
​network.lna.enabled = true
​network.lna.blocking = true
​security.mixed_content.block_active_content = false
​security.mixed_content.block_display_content = false

Steps to reproduce

  1. Open the browser.
  2. Trigger the LNA prompt.
  3. Tap on the "Learn more" link.

Expected behavior

Tapping the "Learn more" link opens the relevant sumo page.

Actual behavior

Tapping the link does nothing; no page or documentation opens.

Device information

  • Firefox version: Fenix 147.0a1 - 27.11.2025
  • Android device model: Google Pixel 10 (Android 16)

This issue is not LNA specific. It is reproducible with the cross-origin storage permission as well. You can reproduce by following these steps (also as seen in the attached recording):

  1. navigate to https://senglehardt.com/test/dfpi/storage_access_api.html
  2. on the 3rd column (different site, cross-origin iframe), scroll to the "Storage Access API" section and click on the requestStorageAccess() button
  3. on the permission prompt - tap on the "Learn more" link.

Expected behavior

Tapping the "Learn more" link opens the relevant sumo page.

Actual behavior

Tapping the link does nothing; no page or documentation opens.

I did a git bisect and found that this regression in behavior started in https://hg.mozilla.org/mozilla-central/rev/eda8bc9983d6 (bug 1980348), so I have marked it as the regressing bug and updated the bug information.

I had a look around, and found that in the SitePermissionsDialogFragment, we dismiss the dialog before we invoke feature?.onLearnMorePress(). That means that we consume the permission request (on dismissal), and by the time we try to handle the click, there is no more a permission request.

Even though this seems like a regression caused by bug 1980348, I think it only uncovered the issue now because things were happening on different threads before now. I think changing the order will fix the issue, but I also think we need to look into making sure we are not consuming the permission prompt before we can handle the learn more link navigation

Keywords: regression
Regressed by: 1980348
See Also: → 1980348
Component: Accounts and Sync → Settings
Summary: The "Learn more" link from the prompt is not functioning → The "Learn more" link on site permissions prompt is not functioning
Assignee: nobody → sfamisa
Status: NEW → ASSIGNED
Whiteboard: [fxdroid] [group1]

Set release status flags based on info from the regressing bug 1980348

This patch fixes the bug clicking the "learn more" link on a permission prompt like cross origin storage, does not open the associated web url.

This is because we dismiss the prompt before handling the click. Dismissing the prompt then causes the permission request to be consumed, such that by the time the learn more click action is being handled, there is no permission request in the state anymore.

Changes:

  • Adjusted the setOnClickListener in SitePermissionsDialogFragment.kt to call onLearnMorePress before dismiss, ensuring the navigation action is triggered.
  • Added a test in SitePermissionTest to cover this behavior

The bug is marked as tracked for firefox147 (nightly). However, the bug still has low severity.

:royang, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(royang)
Pushed by sfamisa@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8d845f554d7c https://hg.mozilla.org/integration/autoland/rev/2b2bdd565177 Clicking the "Learn more" link on site permissions prompt should open the support url r=android-reviewers,matt-tighe
Flags: needinfo?(royang)
Status: ASSIGNED → RESOLVED
Closed: 2 days ago
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: