2002849 - Queue management performance in JS managed microtask queue is insufficient.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

A side effect of this patch to remove the use of PersistentRooted was that queue management overhead became higher due to GC barriers.

In the short term, we should revert that patch. Longer term, we should consider another data structure for the Microtask queue

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 2002849 - Revert "Bug 1997702 - Remove use of PersistentRooted on JSContext for MicroTaskQueues" r?jonco

For now let's focus on the industry benchmark rather than a microbenchmark.

Bug 2002850 has been opened to track further improvement here.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e78b98f730ec
https://hg.mozilla.org/integration/autoland/rev/c6f600003c44
Revert "Bug 1997702 - Remove use of PersistentRooted on JSContext for MicroTaskQueues" r=jonco

Comment 3

[Atila Butkovits]

Backed out for causing xpc failures at test_promise_job_across_sandbox.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/fca2f5e043d75fca3c591850e7822510fd6f1b5d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b3b781fc45ba215f17c601666ab03f3a3b76d1f9&selectedTaskRun=YjGfiVt_SnWCHKuo83khuw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=537842962&repo=autoland&task=YjGfiVt_SnWCHKuo83khuw.0&lineNumber=2679

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/31c1af05c7ee
https://hg.mozilla.org/integration/autoland/rev/82f701e2e54d
Revert "Bug 1997702 - Remove use of PersistentRooted on JSContext for MicroTaskQueues" r=jonco

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/82f701e2e54d