Closed Bug 2003016 Opened 6 months ago Closed 3 months ago

Home button extends across the entire revision search input component

Categories

(Testing :: PerfCompare, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sparky, Assigned: moijes12)

References

Details

(Whiteboard: [pcf])

Attachments

(1 file)

47 bytes, text/x-github-pull-request
Details | Review

Currently, when you have a comparison created, the Home button at the top of the search revision input extends across the entire component even though it should only be restricted to the area where the Home button is (the left side of the search section). This is a bit annoying because sometimes if you click out of the results search, you can easily accidentally click it and it'll return to the home page.

I think the reason the Home button ends up spanning the entire line is because it is a Link which contains block-level elements (Stack uses a <div> and the Home text is contained in <p>). That makes the clickable area expand to the whole row.

Setting the display attribute to inline-flex for the link should fix the issue. We can also add inline-flex to the Stack and <p> to make them consistently inline.

Attached file GitHub Pull Request

Adding a fix

Assignee: nobody → moijes12
See Also: → 1930933
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: