Closed Bug 2003064 Opened 4 months ago Closed 2 months ago

Connect @Mentions

Categories

(Core :: Machine Learning: Frontend, task)

task

Tracking

()

RESOLVED FIXED
149 Branch
Tracking Status
firefox149 --- fixed

People

(Reporter: cbellini, Assigned: flozia)

References

(Blocks 1 open bug)

Details

(Whiteboard: [genai])

Attachments

(5 files, 1 obsolete file)

No description provided.

Adds the status of the multiline editor to Storybook and initial documentation.

Adds support for extending the multiline editor with plugins. The first addition to the multiline editor is the capability to add mentions which are needed for the Smartbar.

Attachment #9536947 - Attachment description: WIP: Bug 2003064 - Part 1: Add multiline editor status and README to Storybook → Bug 2003064 - Part 1: Add multiline editor status and README to Storybook
Attachment #9536948 - Attachment description: WIP: Bug 2003064 - Part 2: Add mentions to the multiline editor → Bug 2003064 - Part 2: Add mentions to the multiline editor

Updates the prosemirror bundle to export functionality to support multiline the editor mentions plugin.

Attachment #9536948 - Attachment description: Bug 2003064 - Part 2: Add mentions to the multiline editor → Bug 2003064 - Part 2.2: Add mentions support to the multiline editor

Updates the prosemirror bundle to export functionality to support multiline the editor mentions plugin.

Attachment #9538727 - Attachment is obsolete: true
Attachment #9538722 - Attachment description: WIP: Bug 2003064 - Part 2.1: Add prosemirror-markdown and prosemirror-suggestions exports → Bug 2003064 - Part 2.1: Add prosemirror-markdown and prosemirror-suggestions exports
Depends on: 2000992

Adds mentions to the Smartbar input to enable tagging open and recently closed tabs.

Attachment #9539436 - Attachment description: WIP: Bug 2003064 - Part 3: Connect mentions with the Smartbar → Bug 2003064 - Part 3: Connect mentions with the Smartbar

Use the website chip component for mentions plus minor styling adjustments to align better with text inline.

Attachment #9540019 - Attachment description: WIP: Bug 2003064, 2003072 - Part 4: Update mention element for the Smartbar → Bug 2003064, 2003072 - Part 4: Update mention element for the Smartbar
Attachment #9540019 - Attachment description: Bug 2003064, 2003072 - Part 4: Update mention element for the Smartbar → Bug 2003064 - Part 4: Update mention element for the Smartbar
Pushed by fzia@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c17415640bbb https://hg.mozilla.org/integration/autoland/rev/d2167491ad01 Part 1: Add multiline editor status and README to Storybook r=ai-frontend-reviewers,Mardak,urlbar-reviewers https://github.com/mozilla-firefox/firefox/commit/c2783ec2b5d1 https://hg.mozilla.org/integration/autoland/rev/94f8643f3004 Part 2.1: Add prosemirror-markdown and prosemirror-suggestions exports r=ai-frontend-reviewers,Mardak https://github.com/mozilla-firefox/firefox/commit/fb3d429a7bc3 https://hg.mozilla.org/integration/autoland/rev/04a1851a857d Part 2.2: Add mentions support to the multiline editor r=desktop-theme-reviewers,ai-frontend-reviewers,ngrato,urlbar-reviewers,hjones https://github.com/mozilla-firefox/firefox/commit/3eec99f3749e https://hg.mozilla.org/integration/autoland/rev/d130e7fe5638 Part 3: Connect mentions with the Smartbar r=urlbar-reviewers,ai-frontend-reviewers,fluent-reviewers,mlucks,mak,flod https://github.com/mozilla-firefox/firefox/commit/7959fc4a2538 https://hg.mozilla.org/integration/autoland/rev/008db40c0ab4 Part 4: Update mention element for the Smartbar r=desktop-theme-reviewers,urlbar-reviewers,ai-frontend-reviewers,ngrato,mak,dao
Blocks: 2003069
Blocks: 2015118
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49]
Flags: qe-verify+
QA Contact: rdoghi

I dont think there is anything for QA to test here but the @mentions panel works and adds those tabs or websites inline.

QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49] → [qa-triage-done-c150/b149]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: