2003197 - Remove unused browser.urlbar.addons.minKeywordLength pref

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, task, P5)

Description

[Gregory Pappas [:gregp]]

It became unused in bug 1836582

Comment 1

[Gregory Pappas [:gregp]]

• browser/app/profile/firefox.js#733-735

Comment 2

[Vignesh Sadankae]

Hi, I’m new to contributing to Mozilla and I’d like to start by working on this bug. I’ve read through the details and I believe this is a good opportunity for me to learn and contribute. Please let me know if anyone is already actively working on it, or if there are any specific guidelines or background information I should be aware of before starting. If possible, I’d be happy to be assigned this bug so I can begin investigating and preparing a patch.
My email: [e-mail]

Comment 3

[Vignesh Sadankae]

Attachment: Bug 2003197 - Remove unused pref network.trr.confirmation_telemetry_enabled

Comment 4

[Phabricator Automation]

Comment on attachment 9531200 [details]
Bug 2003197 - Remove unused pref network.trr.confirmation_telemetry_enabled

Revision D275285 was moved to bug 2003183. Setting attachment 9531200 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f467d4a3f61e
https://hg.mozilla.org/integration/autoland/rev/a6867c1e198b
Remove unused pref network.trr.confirmation_telemetry_enabled r=jesup

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a6867c1e198b

Comment 7

[Mathew Hodson]

The patch https://phabricator.services.mozilla.com/D275285 that landed in https://github.com/mozilla-firefox/firefox/commit/f467d4a3f61e had the wrong bug number so this bug isn't fixed.

The patch actually fixed bug 2003183

Comment 8

[Phabricator Automation]

Comment on attachment 9531200 [details]
Bug 2003197 - Remove unused pref network.trr.confirmation_telemetry_enabled

Revision D275285 was moved to bug 2003183. Setting attachment 9531200 [details] to obsolete.

Comment 9

[Mathew Hodson]

Attachment: Bug 2003197 - Remove browser.urlbar.addons.minKeywordLength pref r=gregp

It became unused in bug 1836582.

Comment 10

[Mathew Hodson]

Bug 1836582 was essentially reverted by bug 2011853 and browser.urlbar.addons.minKeywordLength pref is used again.