2003223 - [wpt-sync] Sync PR 56359 - Digital Credentials: fix abort controller test

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 56359 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/56359
Details from upstream follow.

Marcos Caceres <[e-mail]> wrote:

Digital Credentials: fix abort controller test

The test was calling abort() before making the request, which immediately rejects the promise. The fix:

• Moves abort() call to after the request is initiated
• Uses a custom Error instead of generic AbortError for clearer testing
• Adds proper user activation blessing for each test iteration
• Uses makeGetOptions() with object API for consistency

This ensures we're testing the actual abort behavior during request processing rather than pre-aborted requests.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4aacd057ab9334d7474c860967e485796fa7f18e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 14 tests

Status Summary

Firefox

OK : 6
PASS : 2
FAIL : 27
ERROR: 1[GitHub] 8[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

OK : 1
PASS : 11
FAIL : 2

Safari

OK : 1
PASS : 12
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /digital-credentials/get.tentative.https.html [wpt.fyi]: ERROR

New Tests That Don't Pass

• /digital-credentials/allow-attribute-with-create.https.html [wpt.fyi]
  • With Create: Policy to use: null, is cross-origin: false, is allowed by policy: true: FAIL
  • With Create: Policy to use: null, is cross-origin: true, is allowed by policy: false: FAIL
  • With Create: Policy to use: digital-credentials-create, is cross-origin: false, is allowed by policy: true: FAIL
  • With Create: Policy to use: digital-credentials-create, is cross-origin: true, is allowed by policy: true: FAIL
  • With Create: Policy to use: digital-credentials-create *, is cross-origin: false, is allowed by policy: true: FAIL
  • With Create: Policy to use: digital-credentials-create *, is cross-origin: true, is allowed by policy: true: FAIL
  • With Create: Policy to use: digital-credentials-create 'none', is cross-origin: false, is allowed by policy: false: FAIL
  • With Create: Policy to use: digital-credentials-create 'none', is cross-origin: true, is allowed by policy: false: FAIL
  • With Create: Policy to use: digital-credentials-create 'self', is cross-origin: false, is allowed by policy: true: FAIL
  • With Create: Policy to use: digital-credentials-create 'self', is cross-origin: true, is allowed by policy: false: FAIL
  • With Create: Policy to use: digital-credentials-create https://www1.web-platform.test:8443, is cross-origin: false, is allowed by policy: false: FAIL
  • With Create: Policy to use: digital-credentials-create https://www1.web-platform.test:8443, is cross-origin: true, is allowed by policy: true: FAIL
• /digital-credentials/allow-attribute-with-get.https.html [wpt.fyi]
  • With Get: Policy to use: null, is cross-origin: false, is allowed by policy: true: FAIL
  • With Get: Policy to use: null, is cross-origin: true, is allowed by policy: false: FAIL
  • With Get: Policy to use: digital-credentials-get, is cross-origin: false, is allowed by policy: true: FAIL
  • With Get: Policy to use: digital-credentials-get, is cross-origin: true, is allowed by policy: true: FAIL
  • With Get: Policy to use: digital-credentials-get *, is cross-origin: false, is allowed by policy: true: FAIL
  • With Get: Policy to use: digital-credentials-get *, is cross-origin: true, is allowed by policy: true: FAIL
  • With Get: Policy to use: digital-credentials-get 'none', is cross-origin: false, is allowed by policy: false: FAIL
  • With Get: Policy to use: digital-credentials-get 'none', is cross-origin: true, is allowed by policy: false: FAIL
  • With Get: Policy to use: digital-credentials-get 'self', is cross-origin: false, is allowed by policy: true: FAIL
  • With Get: Policy to use: digital-credentials-get 'self', is cross-origin: true, is allowed by policy: false: FAIL
  • With Get: Policy to use: digital-credentials-get https://www1.web-platform.test:8443, is cross-origin: false, is allowed by policy: false: FAIL
  • With Get: Policy to use: digital-credentials-get https://www1.web-platform.test:8443, is cross-origin: true, is allowed by policy: true: FAIL
• /digital-credentials/create.disabled-by-permissions-policy.https.sub.html [wpt.fyi]: ERROR
• /digital-credentials/create.tentative.https.html [wpt.fyi]: ERROR
• /digital-credentials/default-permissions-policy.https.sub.html [wpt.fyi]: ERROR
• /digital-credentials/digital-credential-user-agent-allows-protocol.https.html [wpt.fyi]
  • User agent does not allow invalid protocol identifiers.: FAIL
• /digital-credentials/digital-credentials-static-methods.tentative.https.html [wpt.fyi]
  • check default isConditionalMediationAvailable() behavior, inherited from Credential interface.: FAIL
  • check default willRequestConditionalCreation() behavior, inherited from Credential interface: FAIL
• /digital-credentials/enabled-on-self-origin-by-permissions-policy.https.sub.html [wpt.fyi]: ERROR
• /digital-credentials/get.disabled-by-permissions-policy.https.sub.html [wpt.fyi]: ERROR
• /digital-credentials/get.tentative.https.html [wpt.fyi]: ERROR (Chrome: OK, Safari: OK)
• /digital-credentials/non-fully-active.https.html [wpt.fyi]: ERROR
• /digital-credentials/user-activation.https.html [wpt.fyi]: ERROR

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/00383feaa7df
https://hg.mozilla.org/integration/autoland/rev/8cc5b2957a08
[wpt PR 56359] - Digital Credentials: fix abort controller test, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8cc5b2957a08