2003230 - Optimize chunk_by_runtime.get_manifest in the Linux case

Status: RESOLVED FIXED

(Testing :: Mozbase, task)

Description

[[:sergesanspaille]]

This static method shows up at the top of the profile in terms of time spent in the function itself, excluding callees, so it's worth optimizing it.

Comment 1

[[:sergesanspaille]]

Attachment: Bug 2003230 - optimize chunk_by_runtime.get_manifest for the Linux case r=jcristau!

Optimizing get_manifest in the common case of os.sep == '/' yields a
nice 138ms gain on task graph rebuild.

% hyperfine -L branch experiment/try-validate^,experiment/try-validate -w1 -r5 -s 'git checkout {branch}' 'TASKGRAPH_SERIAL=1 ./mach taskgraph full -k mochitest'
Benchmark 1: TASKGRAPH_SERIAL=1 ./mach taskgraph full -k mochitest (branch = experiment/try-validate^)
Time (mean ± σ): 19.569 s ± 0.081 s [User: 19.841 s, System: 2.932 s]
Range (min … max): 19.440 s … 19.653 s 5 runs

Benchmark 2: TASKGRAPH_SERIAL=1 ./mach taskgraph full -k mochitest (branch = experiment/try-validate)
Time (mean ± σ): 19.431 s ± 0.077 s [User: 19.676 s, System: 3.008 s]
Range (min … max): 19.343 s … 19.511 s 5 runs

Summary
TASKGRAPH_SERIAL=1 ./mach taskgraph full -k mochitest (branch = experiment/try-validate) ran
1.01 ± 0.01 times faster than TASKGRAPH_SERIAL=1 ./mach taskgraph full -k mochitest (branch = experiment/try-validate^)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/60d9b065fa0f
https://hg.mozilla.org/integration/autoland/rev/d90114d65e5e
optimize chunk_by_runtime.get_manifest for the Linux case r=jcristau

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2f8f70d930c5
https://hg.mozilla.org/integration/autoland/rev/89f408b23951
Revert "Bug 2003230 - optimize chunk_by_runtime.get_manifest for the Linux case r=jcristau" for causing linting failures.

Comment 4

[agoloman]

Backed out for causing linting failures.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f5bd73e84bdc
https://hg.mozilla.org/integration/autoland/rev/af79ab9f261e
optimize chunk_by_runtime.get_manifest for the Linux case r=jcristau

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/af79ab9f261e