Closed Bug 2003307 Opened 2 months ago Closed 2 months ago

Open about:newtab or default start page by default on restore

Categories

(Firefox :: Profile Backup, task, P1)

Product:
Firefox
Component:
Profile Backup
Type:
task

Tracking

()

Status:
VERIFIED FIXED
Milestone:
147 Branch
Tracking Flags:
Tracking Status
firefox146 --- verified
firefox147 --- verified
firefox148 --- verified

People

(Reporter: hsohaney, Assigned: hsohaney)

References

Details

(Whiteboard: [fidedi])

Attachments

(2 files, 1 obsolete file)

Bug 2003307 - Open the user's start page by default on restore. r=cdupuis,#backup-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2003307 - Open the user's start page by default on restore.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-release+
Details | Review

We should open about:newtab or the user's custom home page on restore to avoid problems around the messaging system.

Assignee: nobody → hsohaney
Severity: -- → S3
Priority: -- → P1
Whiteboard: [fidedi]
Attached file WIP: Bug 2003307 - Test updates. WIP (obsolete) —
Attachment #9530121 - Attachment is obsolete: true

https://hg.mozilla.org/mozilla-central/rev/38abe0bb259e

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox147: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
QA Whiteboard: [qa-triage-done-c148/b147][qa-ver-needed-c148/b147]
Flags: qe-verify+

Verified on both Win10/Win11 and Firefox 147.0b2 and 148.0a1 that the about:newtab is displayed after restore.

status-firefox147: fixed → verified
status-firefox148: --- → verified
QA Whiteboard: [qa-triage-done-c148/b147][qa-ver-needed-c148/b147] → [qa-triage-done-c148/b147][qa-ver-done-c148/b147]
Flags: qe-verify+
QA Contact: mchiorean

firefox-release Uplift Approval Request

  • User impact if declined: This patch makes the restore option open new tab by default, which helps avoid breakage with the spotlight when opening on a regular tab. This should help avoid any errors with the spotlight getting dismissed unexpectedly on restore.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Uses the cmd line options to open new tab by default on restore
  • String changes made/needed: No
  • Is Android affected?: no
Attachment #9532367 - Flags: approval-mozilla-release?
Attachment #9532367 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified issue as fixed on Win10/Win11 using FF build 146.0.1.

Status: RESOLVED → VERIFIED
status-firefox146: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: