Broken accent colors in Manjaro GNOME
Categories
(Core :: Widget: Gtk, defect, P3)
Tracking
()
People
(Reporter: carlp2461, Unassigned)
References
(Blocks 1 open bug)
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:145.0) Gecko/20100101 Firefox/145.0
Steps to reproduce:
Attempt to switch the GNOME accent color to "Manjaro Maia" and then launch Firefox.
Actual results:
The accent color is not correctly detected. My guess is the issue is either:
- There's a hard-coded list of accent colors for GNOME, which is extremely brittle (breaks if GNOME or downstream distros add support for a new accent color).
- The code can't handle spaces in color names.
Expected results:
Accent color should be set to Manjaro Maia.
Comment 1•11 months ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 2•11 months ago
|
||
We moved away from native theming so I'm not sure we can follow any custom theme - we try to get basic colors and use them.
Updated•11 months ago
|
Updated•11 months ago
|
Updated•11 months ago
|
| Reporter | ||
Comment 3•11 months ago
|
||
(In reply to Martin Stránský [:stransky] (ni? me) from comment #2)
We moved away from native theming so I'm not sure we can follow any custom theme - we try to get basic colors and use them.
Yep, this is not a custom theme. The problem is Firefox isn't picking up the correct basic accent color. TBC, this is the color I chose in the GNOME settings (under "Appearance"), not a GTK theme, and it works with any color except for Maia.
Comment 4•10 months ago
|
||
Hmm, accent color seems to be taken from selected color. I don't even know how to repro this but could it be a gtk3 bug? Emilio probably knows what is going on. :)
https://searchfox.org/firefox-main/source/widget/gtk/nsLookAndFeel.cpp#2489
Comment 5•10 months ago
|
||
Can you attach a with MOZ_LOG=LookAndFeel:5 firefox? We get the accent color from the dbus settings daemon, and they are three doubles, so no color name involved: https://searchfox.org/firefox-main/rev/33bba5cfe4a89dda0ee07fa9fbac578353713fd3/widget/gtk/nsLookAndFeel.cpp#223
Comment 6•10 months ago
|
||
Ok, so it's coming from gsettings then.
$ gsettings range org.gnome.desktop.interface accent-color
| Reporter | ||
Comment 7•4 months ago
|
||
Ok, so it's coming from gsettings then.
$ gsettings range org.gnome.desktop.interface accent-color
Don't know anything about Firefox, but just learned this can be pulled from dbus using:
dbus-send --print-reply --dest=org.freedesktop.portal.Desktop \
/org/freedesktop/portal/desktop \
org.freedesktop.portal.Settings.Read \
string:"org.freedesktop.appearance" string:"accent-color"(In reply to Jens Persson from comment #6)
Description
•