Closed
Bug 2003421
Opened 7 months ago
Closed 5 months ago
Align Button colors with M3 specs
Categories
(Firefox for Android :: Design System and Theming, task, P3)
Tracking
()
RESOLVED
FIXED
149 Branch
| Tracking | Status | |
|---|---|---|
| firefox149 | --- | fixed |
People
(Reporter: gl, Assigned: lmccracken)
References
(Blocks 3 open bugs)
Details
(Whiteboard: [fxdroid][group4])
Attachments
(1 file)
There are a couple of issues with the existing colors used in Button.kt which warrants a bit of an investigation.
- OutlinedButton is currently relying on the button defaults, which differs from the Figma. In the designs, OutlinedButton is using "Primary" text color vs "OnSurfaceVariant" from the defaults. We should check with UX whether or not the designs are out of date or whether we should continue to align with Figma designs as an intentional deviation from the defaults.
- The current DestructiveButton implementation is using the colors of the hovered state from the Figma. We want to remove the background color so that it actually resembles the Enabled State https://www.figma.com/design/MjufE1X5fvkxZ0YneX4kRd/Android-Library--2025-?node-id=64529-34813&m=dev.
Updated•7 months ago
|
Updated•7 months ago
|
Whiteboard: [fxdroid] → [fxdroid][group4]
| Reporter | ||
Updated•6 months ago
|
Blocks: m3-specs-update
| Assignee | ||
Updated•6 months ago
|
Assignee: nobody → lmccracken
| Assignee | ||
Comment 1•6 months ago
|
||
Updated•6 months ago
|
Attachment #9536595 -
Attachment description: WIP: Bug 2003421 : update button colours to align with the M3 specs → Bug 2003421 : update button colours to align with the M3 specs
| Assignee | ||
Updated•6 months ago
|
Status: NEW → ASSIGNED
| Reporter | ||
Comment 2•6 months ago
|
||
OutlinedButton is currently relying on the button defaults, which differs from the Figma. In the designs, OutlinedButton is using "Primary" text color vs "OnSurfaceVariant" from the defaults. We should check with UX whether or not the designs are out of date or whether we should continue to align with Figma designs as an intentional deviation from the defaults.
Confirmed with Maggie in https://mozilla.slack.com/archives/C03KPTP37BN/p1767966473905139 that the content color for OutlinedButton should align with the Figma and use the Primary color token.
Pushed by lmccracken@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a18e36fc0955
https://hg.mozilla.org/integration/autoland/rev/65f13c6660e9
update button colours to align with the M3 specs r=android-reviewers,gl
Comment 4•5 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox149:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•