2003461 - Use StringChars instead of JSStringBuilder for toBase64/toHex

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P1)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 2003461: Use StringChars instead of JSStringBuilder for toBase64/toHex. r=iain!

StringChars allows to directly pass the allocated characters to the result JSString*.

Comment 2

[Mike Kasprzak]

Similar perf (if not better) than my ugly patch. I also like that it localizes the Append code to the ToBase64 function, as that will make SIMD'ing or coaxing the auto-vectorizer easier. I was not liking the circular paths that tracing infallibleAppend was taking me down.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bba50f0189be
https://hg.mozilla.org/integration/autoland/rev/eb91afc120a7
Use StringChars instead of JSStringBuilder for toBase64/toHex. r=iain

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/eb91afc120a7