2003720 - Back out sync-about-blank (bug 543435) from 147 beta

Status: ASSIGNED

(Core :: DOM: Navigation, task)

Description

[Henri Sivonen (:hsivonen)]

We expect not to be able to address the regressions from bug 543435 in time for Firefox 147, but we need the changes on Nightly in order to get data about what's failing (notably the issues that appear to relate to extensions). Therefore, let's back out bug 543435 and changes that build upon it from the beta branch right after 147 has branched from Nightly to Beta.

See the currently known list of items that need action.

I'll prepare a Lando stack to experiment ahead of time.

Comment 1

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=166736

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 2002313 - Continue to fail tests for bug 1429507 silently if window.open fails. r=webrtc-reviewers,dom-core,smaug,pehrsons" from beta.

This reverts commit 5980df272ec0cb9026ceb173b38597272688a463.

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 2002024 - Remove hack that shouldn't be needed now that we have sync about:blank. r=hsivonen" from beta.

This reverts commit 4d5c12d5fb2e029a888eac10ff3c84acbb5c3a0b.

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 2001934 - Fix Puppeteer Page.goto timeout for 204 page. r=whimboo" from beta.

This reverts commit e68671efd8c8e76073e6a9e5c61afad383b62ce1.

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 2002189 - Remove nsIDTD. r=dom-core,edgar,smaug" from beta.

This reverts commit 8cfad39176be94c2534ada4abc8c693998f48026.

Comment 6

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 650775 - Remove CNavDTD and nsIHTMLContentSink from the tree. r=dom-core,farre" from beta.

This reverts commit 326cf8e6a032402327988b8d04673cb70d11628d.

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 563890 - Rename nsHTMLContentSink.cpp to HTMLElementFactory.cpp for consistency with SVG and MathML. r=dom-core,farre" from beta.

This reverts commit bf8e6315c253a54f3ff200515685df7d88df71b5.

Comment 8

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 543435 - Only reuse inner window for uncommitted initial documents. r=smaug,asuth,credential-management-reviewers,webrtc-reviewers,pehrsons,hsivonen,dimi" from beta.

This reverts commit 9812cb264720210ab5728332161938cbc8be5eba.

Comment 9

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 543435 - Ensure the initial about:blank SH entry is replaced. r=smaug" from beta.

This reverts commit 967fc6d445e4e7bfc2d8df824b2e47c59b47e8f8.

Comment 10

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 2002313 - Continue to fail tests for bug 1429507 silently if window.open fails. r=webrtc-reviewers,dom-core,smaug,pehrsons" from beta.

This reverts commit 5980df272ec0cb9026ceb173b38597272688a463.

Comment 11

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 2002024 - Remove hack that shouldn't be needed now that we have sync about:blank. r=hsivonen" from beta.

This reverts commit 4d5c12d5fb2e029a888eac10ff3c84acbb5c3a0b.

Comment 12

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 2001934 - Fix Puppeteer Page.goto timeout for 204 page. r=whimboo" from beta.

This reverts commit e68671efd8c8e76073e6a9e5c61afad383b62ce1.

Comment 13

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 2002189 - Remove nsIDTD. r=dom-core,edgar,smaug" from beta.

This reverts commit 8cfad39176be94c2534ada4abc8c693998f48026.

Comment 14

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 650775 - Remove CNavDTD and nsIHTMLContentSink from the tree. r=dom-core,farre" from beta.

This reverts commit 326cf8e6a032402327988b8d04673cb70d11628d.

Comment 15

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 563890 - Rename nsHTMLContentSink.cpp to HTMLElementFactory.cpp for consistency with SVG and MathML. r=dom-core,farre" from beta.

This reverts commit bf8e6315c253a54f3ff200515685df7d88df71b5.

Comment 16

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 543435 - Only reuse inner window for uncommitted initial documents. r=smaug,asuth,credential-management-reviewers,webrtc-reviewers,pehrsons,hsivonen,dimi" from beta.

This reverts commit 9812cb264720210ab5728332161938cbc8be5eba.

Comment 17

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 543435 - Ensure the initial about:blank SH entry is replaced. r=smaug" from beta.

This reverts commit 967fc6d445e4e7bfc2d8df824b2e47c59b47e8f8.

Comment 18

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revert "Bug 543435 - Make initial about:blank not get overwritten by an async about:blank load." from beta.

This reverts commit 39a8a4171bb2248c50f158f0d144474e21924db9.

Comment 19

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Disable content-security-policy/inheritance/document-write-iframe.html (changed in bug 2002073) on beta.

Comment 20

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Flip dom.about-blank-ckeditor-hack.enabled to disable the effect of bug 2002481 on beta.

Comment 21

[Henri Sivonen (:hsivonen)]

Release Note Request (optional, but appreciated)
[Why is this notable]: The relnote for bug 543435 needs to be moved from 147 to 148
[Affects Firefox for Android]: Yes
[Suggested wording]: (Moving the existing wording from 147 to 148)
[Links (documentation, blog post, etc)]:

Comment 22

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=166781

Comment 23

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Disable document-base-url-changes-about-srcdoc-2.https.html and frame-src-javascript-url.html to avoid a timeout.

Comment 24

[Henri Sivonen (:hsivonen)]

Attachment: WIP: Bug 2003720 - Revise expectation for custom-elements/registries/per-document.html.