Closed Bug 2003720 Opened 9 months ago Closed 9 months ago

Back out sync-about-blank (bug 543435) from 147 beta

Categories

(Core :: DOM: Navigation, task)

Product:
Core
Component:
DOM: Navigation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
147 Branch
Tracking Flags:
Tracking Status
firefox147 + fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(16 files, 9 obsolete files)

Bug 2003720 - Revert "Bug 2002313 - Continue to fail tests for bug 1429507 silently if window.open fails. r=webrtc-reviewers,dom-core,smaug,pehrsons" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 2002024 - Remove hack that shouldn't be needed now that we have sync about:blank. r=hsivonen" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 2001934 - Fix Puppeteer Page.goto timeout for 204 page. r=whimboo" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 2002189 - Remove nsIDTD. r=dom-core,edgar,smaug" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 650775 - Remove CNavDTD and nsIHTMLContentSink from the tree. r=dom-core,farre" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 563890 - Rename nsHTMLContentSink.cpp to HTMLElementFactory.cpp for consistency with SVG and MathML. r=dom-core,farre" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 543435 - Only reuse inner window for uncommitted initial documents. r=smaug,asuth,credential-management-reviewers,webrtc-reviewers,pehrsons,hsivonen,dimi" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 543435 - Ensure the initial about:blank SH entry is replaced. r=smaug" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 543435 - Make initial about:blank not get overwritten by an async about:blank load." from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Disable content-security-policy/inheritance/document-write-iframe.html (changed in bug 2002073) on beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Flip dom.about-blank-ckeditor-hack.enabled to disable the effect of bug 2002481 on beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Disable document-base-url-changes-about-srcdoc-2.https.html and frame-src-javascript-url.html to avoid a timeout.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revise expectation for custom-elements/registries/per-document.html.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Revert "Bug 2003255 - Force sync about:blank despite busy DocLoader. r=dom-core,smaug" from beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Disable test_ckeditor4_compat_hack.html on beta.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review
Bug 2003720 - Remove duplicate method in remote/webdriver-bidi/modules/windowglobal/_configuration.sys.mjs.
48 bytes, text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details | Review

We expect not to be able to address the regressions from bug 543435 in time for Firefox 147, but we need the changes on Nightly in order to get data about what's failing (notably the issues that appear to relate to extensions). Therefore, let's back out bug 543435 and changes that build upon it from the beta branch right after 147 has branched from Nightly to Beta.

See the currently known list of items that need action.

I'll prepare a Lando stack to experiment ahead of time.

This reverts commit 4d5c12d5fb2e029a888eac10ff3c84acbb5c3a0b.

This reverts commit e68671efd8c8e76073e6a9e5c61afad383b62ce1.

This reverts commit 8cfad39176be94c2534ada4abc8c693998f48026.

This reverts commit 326cf8e6a032402327988b8d04673cb70d11628d.

This reverts commit 967fc6d445e4e7bfc2d8df824b2e47c59b47e8f8.

This reverts commit e68671efd8c8e76073e6a9e5c61afad383b62ce1.

This reverts commit 8cfad39176be94c2534ada4abc8c693998f48026.

This reverts commit 326cf8e6a032402327988b8d04673cb70d11628d.

This reverts commit 967fc6d445e4e7bfc2d8df824b2e47c59b47e8f8.

Release Note Request (optional, but appreciated)
[Why is this notable]: The relnote for bug 543435 needs to be moved from 147 to 148
[Affects Firefox for Android]: Yes
[Suggested wording]: (Moving the existing wording from 147 to 148)
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?

Bug 2003693 and bug 2003255 need to be backed out too once they are in the tree.

(In reply to Vincent Hilla [:vhilla] from comment #25)

Bug 2003693 and bug 2003255 need to be backed out too once they are in the tree.

Bug 2003693 is already covered by a pref flip in the patch stack.

(In reply to Henri Sivonen (:hsivonen) from comment #26)

(In reply to Vincent Hilla [:vhilla] from comment #25)

Bug 2003693 and bug 2003255 need to be backed out too once they are in the tree.

Bug 2003693 is already covered by a pref flip in the patch stack.

No, I added dom/base/test/test_ckeditor4_compat_hack.html. Sorry, I realize just now the test would've passed on beta too without the test_sanity_sync_load. We could also remove that subtest.

This reverts commit e1d22ea27f3632f31e15b603fa1b6a3029d30221.

(In reply to Vincent Hilla [:vhilla] from comment #27)

(In reply to Henri Sivonen (:hsivonen) from comment #26)

(In reply to Vincent Hilla [:vhilla] from comment #25)

Bug 2003693 and bug 2003255 need to be backed out too once they are in the tree.

Bug 2003693 is already covered by a pref flip in the patch stack.

No, I added dom/base/test/test_ckeditor4_compat_hack.html. Sorry, I realize just now the test would've passed on beta too without the test_sanity_sync_load. We could also remove that subtest.

Good point. I disabled the test.

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=167244

(In reply to Henri Sivonen (:hsivonen) from comment #21)

Release Note Request (optional, but appreciated)

I've removed the note from the 147 Beta relnotes and updated the flag on the other bug accordingly.

relnote-firefox: ? → ---

(In reply to Ryan VanderMeulen [:RyanVM] from comment #31)

(In reply to Henri Sivonen (:hsivonen) from comment #21)

Release Note Request (optional, but appreciated)

I've removed the note from the 147 Beta relnotes and updated the flag on the other bug accordingly.

Thanks!

Also should be backed out just in case even if possibly not totally necessary to back out:
Bug 2003244 - Crash in [@ IPCError-content | RecvConstructBrowser BrowserChild::Init failed]

(In reply to Henri Sivonen (:hsivonen) from comment #30)

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=167244

Looks like the stack was missing some WebDriver-related patch.

This reverts commit c6acc0cb971f8d0c32f65a573f12b5c5a6a0cffc.

Rebased to beta, with another duplicate removed:
https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=167719

Rebased onto three more changesets from beta:
https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=167725

Attachment #9531044 - Attachment description: WIP: Bug 2003720 - Revert "Bug 2003255 - Force sync about:blank despite busy DocLoader. r=dom-core,smaug" from beta. → Bug 2003720 - Revert "Bug 2003255 - Force sync about:blank despite busy DocLoader. r=dom-core,smaug" from beta.
Attachment #9531045 - Attachment description: WIP: Bug 2003720 - Disable test_ckeditor4_compat_hack.html on beta. → Bug 2003720 - Disable test_ckeditor4_compat_hack.html on beta.
Attachment #9530550 - Attachment description: WIP: Bug 2003720 - Revert "Bug 2002313 - Continue to fail tests for bug 1429507 silently if window.open fails. r=webrtc-reviewers,dom-core,smaug,pehrsons" from beta. → Bug 2003720 - Revert "Bug 2002313 - Continue to fail tests for bug 1429507 silently if window.open fails. r=webrtc-reviewers,dom-core,smaug,pehrsons" from beta.
Attachment #9530551 - Attachment description: WIP: Bug 2003720 - Revert "Bug 2002024 - Remove hack that shouldn't be needed now that we have sync about:blank. r=hsivonen" from beta. → Bug 2003720 - Revert "Bug 2002024 - Remove hack that shouldn't be needed now that we have sync about:blank. r=hsivonen" from beta.
Attachment #9530552 - Attachment description: WIP: Bug 2003720 - Revert "Bug 2001934 - Fix Puppeteer Page.goto timeout for 204 page. r=whimboo" from beta. → Bug 2003720 - Revert "Bug 2001934 - Fix Puppeteer Page.goto timeout for 204 page. r=whimboo" from beta.
Attachment #9530553 - Attachment description: WIP: Bug 2003720 - Revert "Bug 2002189 - Remove nsIDTD. r=dom-core,edgar,smaug" from beta. → Bug 2003720 - Revert "Bug 2002189 - Remove nsIDTD. r=dom-core,edgar,smaug" from beta.
Attachment #9530554 - Attachment description: WIP: Bug 2003720 - Revert "Bug 650775 - Remove CNavDTD and nsIHTMLContentSink from the tree. r=dom-core,farre" from beta. → Bug 2003720 - Revert "Bug 650775 - Remove CNavDTD and nsIHTMLContentSink from the tree. r=dom-core,farre" from beta.
Attachment #9530555 - Attachment description: WIP: Bug 2003720 - Revert "Bug 563890 - Rename nsHTMLContentSink.cpp to HTMLElementFactory.cpp for consistency with SVG and MathML. r=dom-core,farre" from beta. → Bug 2003720 - Revert "Bug 563890 - Rename nsHTMLContentSink.cpp to HTMLElementFactory.cpp for consistency with SVG and MathML. r=dom-core,farre" from beta.
Attachment #9530556 - Attachment description: WIP: Bug 2003720 - Revert "Bug 543435 - Only reuse inner window for uncommitted initial documents. r=smaug,asuth,credential-management-reviewers,webrtc-reviewers,pehrsons,hsivonen,dimi" from beta. → Bug 2003720 - Revert "Bug 543435 - Only reuse inner window for uncommitted initial documents. r=smaug,asuth,credential-management-reviewers,webrtc-reviewers,pehrsons,hsivonen,dimi" from beta.
Attachment #9530557 - Attachment description: WIP: Bug 2003720 - Revert "Bug 543435 - Ensure the initial about:blank SH entry is replaced. r=smaug" from beta. → Bug 2003720 - Revert "Bug 543435 - Ensure the initial about:blank SH entry is replaced. r=smaug" from beta.
Attachment #9530558 - Attachment description: WIP: Bug 2003720 - Revert "Bug 543435 - Make initial about:blank not get overwritten by an async about:blank load." from beta. → Bug 2003720 - Revert "Bug 543435 - Make initial about:blank not get overwritten by an async about:blank load." from beta.
Attachment #9530559 - Attachment description: WIP: Bug 2003720 - Disable content-security-policy/inheritance/document-write-iframe.html (changed in bug 2002073) on beta. → Bug 2003720 - Disable content-security-policy/inheritance/document-write-iframe.html (changed in bug 2002073) on beta.
Attachment #9530560 - Attachment description: WIP: Bug 2003720 - Flip dom.about-blank-ckeditor-hack.enabled to disable the effect of bug 2002481 on beta. → Bug 2003720 - Flip dom.about-blank-ckeditor-hack.enabled to disable the effect of bug 2002481 on beta.
Attachment #9530606 - Attachment description: WIP: Bug 2003720 - Disable document-base-url-changes-about-srcdoc-2.https.html and frame-src-javascript-url.html to avoid a timeout. → Bug 2003720 - Disable document-base-url-changes-about-srcdoc-2.https.html and frame-src-javascript-url.html to avoid a timeout.
Attachment #9530608 - Attachment description: WIP: Bug 2003720 - Revise expectation for custom-elements/registries/per-document.html. → Bug 2003720 - Revise expectation for custom-elements/registries/per-document.html.
Attachment #9531461 - Attachment description: WIP: Bug 2003720 - Remove duplicate method in remote/webdriver-bidi/modules/windowglobal/_configuration.sys.mjs. → Bug 2003720 - Remove duplicate method in remote/webdriver-bidi/modules/windowglobal/_configuration.sys.mjs.
Attachment #9530541 - Attachment is obsolete: true
Attachment #9530542 - Attachment is obsolete: true
Attachment #9530543 - Attachment is obsolete: true
Attachment #9530544 - Attachment is obsolete: true
Attachment #9530545 - Attachment is obsolete: true
Attachment #9530546 - Attachment is obsolete: true
Attachment #9530547 - Attachment is obsolete: true
Attachment #9531451 - Attachment is obsolete: true
Attachment #9530548 - Attachment is obsolete: true
Attachment #9531044 - Flags: approval-mozilla-beta+
Attachment #9531045 - Flags: approval-mozilla-beta+
Attachment #9530550 - Flags: approval-mozilla-beta+
Attachment #9530551 - Flags: approval-mozilla-beta+
Attachment #9530552 - Flags: approval-mozilla-beta+
Attachment #9530553 - Flags: approval-mozilla-beta+
Attachment #9530554 - Flags: approval-mozilla-beta+
Attachment #9530555 - Flags: approval-mozilla-beta+
Attachment #9530556 - Flags: approval-mozilla-beta+
Attachment #9530557 - Flags: approval-mozilla-beta+
Attachment #9530558 - Flags: approval-mozilla-beta+
Attachment #9530559 - Flags: approval-mozilla-beta+
Attachment #9530560 - Flags: approval-mozilla-beta+
Attachment #9530606 - Flags: approval-mozilla-beta+
Attachment #9530608 - Flags: approval-mozilla-beta+
Attachment #9531461 - Flags: approval-mozilla-beta+
https://github.com/mozilla-firefox/firefox/commit/8dbfa6b53173 https://hg.mozilla.org/releases/mozilla-beta/rev/f5dd1ba75b8b https://github.com/mozilla-firefox/firefox/commit/1d8f2b20771a https://hg.mozilla.org/releases/mozilla-beta/rev/a7e567e02a90 https://github.com/mozilla-firefox/firefox/commit/6cc9ed792357 https://hg.mozilla.org/releases/mozilla-beta/rev/dbef4dec5e96 https://github.com/mozilla-firefox/firefox/commit/cbdcee67f085 https://hg.mozilla.org/releases/mozilla-beta/rev/9acbd56f5a09 https://github.com/mozilla-firefox/firefox/commit/d7fe2f74f755 https://hg.mozilla.org/releases/mozilla-beta/rev/365f1b7bffae https://github.com/mozilla-firefox/firefox/commit/5badddb700cd https://hg.mozilla.org/releases/mozilla-beta/rev/d20f3ae60327 https://github.com/mozilla-firefox/firefox/commit/5c445ca755cd https://hg.mozilla.org/releases/mozilla-beta/rev/1e45b467b29e https://github.com/mozilla-firefox/firefox/commit/7df77899e45f https://hg.mozilla.org/releases/mozilla-beta/rev/d13efc018935 https://github.com/mozilla-firefox/firefox/commit/96f7a757157e https://hg.mozilla.org/releases/mozilla-beta/rev/592ba0e5012a https://github.com/mozilla-firefox/firefox/commit/48ab723778d0 https://hg.mozilla.org/releases/mozilla-beta/rev/19309daaa779 https://github.com/mozilla-firefox/firefox/commit/19a13d0c1f6b https://hg.mozilla.org/releases/mozilla-beta/rev/f2e00c2db144 https://github.com/mozilla-firefox/firefox/commit/1148790c4a28 https://hg.mozilla.org/releases/mozilla-beta/rev/0a022f1b29ab https://github.com/mozilla-firefox/firefox/commit/a56e18f2c99c https://hg.mozilla.org/releases/mozilla-beta/rev/934b7981ffd0 https://github.com/mozilla-firefox/firefox/commit/142a5cac9712 https://hg.mozilla.org/releases/mozilla-beta/rev/bb94c76b659f https://github.com/mozilla-firefox/firefox/commit/3ea042cad77c https://hg.mozilla.org/releases/mozilla-beta/rev/794eb59651e3 https://github.com/mozilla-firefox/firefox/commit/5649669d4c7d https://hg.mozilla.org/releases/mozilla-beta/rev/8fedd78286aa
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 147 Branch
Regressions: 2004766
Regressions: 2004769
QA Whiteboard: [qa-triage-done-c148/b147]
See Also: → 2005874
See Also: → sync-about-blank
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: