Closed Bug 2003759 Opened 11 months ago Closed 10 months ago

Use distinct error codes for failures to create the initial about:blank

Categories

(Core :: DOM: Navigation, task)

task

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 external file, 1 obsolete file)

Diagnostics for bug 2003244

It makes less sense to mint a bunch of nsresult values. Using crash annotations with unique numbers instead.

Attachment #9530587 - Attachment is obsolete: true
See Also: → 2003244
See Also: → 2006305
Pushed by vhilla@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/857dc0c7fe05 https://hg.mozilla.org/integration/autoland/rev/f5867c20cf5e Add crash annotations for docshell initialization failure reasons. r=hsivonen,gsvelto
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4b85427200b8 https://hg.mozilla.org/integration/autoland/rev/d582d3ca95bd Revert "Bug 2003759 - Add crash annotations for docshell initialization failure reasons. r=hsivonen,gsvelto" for causing bustages at nsWebBrowser.cpp.

Looks like at least some build configs are more picky about integer types.

Flags: needinfo?(hsivonen) → needinfo?(vhilla)

:gsvelto pointed out that this crash happened on try and I got it reproduced, see bug 2003244. I suggest we wait with adding annotations.

Flags: needinfo?(vhilla)

The crash is fixed, so I we won't need to add annotations.

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: