2003793 - Add priorityHeader marker to profiler

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

While we currently include the class of service flags and nsISupportsPriority, it is difficult to actually figure out what the priority header the server gets is going to be.
I propose including that in the profiler markers directly.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 2003793 - Add priorityHeader marker to profiler r=acreskey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f4d169b146b3
https://hg.mozilla.org/integration/autoland/rev/6ff4e79e756d
Add priorityHeader marker to profiler r=acreskey,necko-reviewers,kershaw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/944bc53c35bf
https://hg.mozilla.org/integration/autoland/rev/765074ad112f
Revert "Bug 2003793, Bug 2003751 - Add priorityHeader marker to profiler r=acreskey,necko-reviewers,kershaw" for causing build bustages @GeckoProfiler.cpp.

Comment 4

[agoloman]

Backed out for causing build bustages @GeckoProfiler.cpp.

• Backout link
• Push with failures
• Failure Log @GeckoProfiler.cpp.
• Failure Log @browser_test_marker_network_cancel.js
• Failure Log @test_rel_preconnect.html

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f039e2a49479
https://hg.mozilla.org/integration/autoland/rev/f681acf7706a
Add priorityHeader marker to profiler r=acreskey,necko-reviewers,kershaw,profiler-reviewers,canaltinova

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/34902b99939d
https://hg.mozilla.org/integration/autoland/rev/b9c027258b53
Revert "Bug 2003793 - Add priorityHeader marker to profiler r=acreskey,necko-reviewers,kershaw,profiler-reviewers,canaltinova" for causing failures at browser_test_marker_network_cancel.js.

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_test_marker_network_cancel.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/b9c027258b53b0e2ce27f2537c79eeabf3d658e6

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f681acf7706add12f6d849026775ce28e206919f

Failure log: https://treeherder.mozilla.org/logviewer?job_id=540280079&repo=autoland&task=emd36jOhRimxIBcTFqxMpg.0&lineNumber=4385

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5c49f08417b3
https://hg.mozilla.org/integration/autoland/rev/7cd297ab8c51
Add priorityHeader marker to profiler r=acreskey,necko-reviewers,kershaw,profiler-reviewers,canaltinova

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7cd297ab8c51