Open Bug 2003826 Opened 5 months ago Updated 2 months ago

android: tjoy.jp - Zoom does not work correctly on seat reservation

Categories

(Web Compatibility :: Site Reports, defect, P1)

Firefox 147
Unspecified
Android

Tracking

(Webcompat Priority:P3, Webcompat Score:1)

Webcompat Priority P3
Webcompat Score 1

People

(Reporter: canalun, Assigned: canalun)

References

()

Details

(4 keywords, Whiteboard: [webcompat:japan])

User Story

user-impact-score:0
platform:android
impact:workflow-broken
configuration:general
affects:all
branch:release
diagnosis-team:layout

Attachments

(1 file)

Environment
147.0a1 (Build #2016129823), 9336a9aece4
GV: 147.0a1-20251203092053
AS: 147.20251202050421
OS: Android 16

Step To Reproduce:

AR
Zoomed in to the top seat in the left column.

ER
Zoomed in to the tapped seat.

FYI: It's very similar to bug1975653, which is already resolved.

OS: Unspecified → Android
See Also: → 1975653
Summary: tjoy.jp - Zoom does not work correctly on seat reservation → android: tjoy.jp - Zoom does not work correctly on seat reservation
Whiteboard: [webcompat:japan]

I'll take a look on it.

Assignee: nobody → i.am.kanaru.sato
User Story: (updated)
Webcompat Score: --- → 1

It's unclear if you can actually finish a reservation or not. Let's triage this as workflow-broken for now, but if you can scroll down, it would just be a notable annoyance.

Severity: -- → S2
User Story: (updated)
Webcompat Priority: --- → P1
Webcompat Score: 1 → 8
Priority: -- → P1

This is almost certainly caused by:

        // Zoom map
        $('div.js-map').css({
            'zoom': 3,
            '-moz-transform': 'scale(3,3)',
            '-webkit-transition': 'scale(3,3)',
            'transform-origin': 'left top',
        });

Emilio/Tom what's the recommended solution to zoom + -moz-transform these days?

Flags: needinfo?(twisniewski)
Flags: needinfo?(emilio)

An intervention with .js-map { -moz-transform: none !important } seems like it'd do.

Flags: needinfo?(emilio)

Sorry I couldn't take time. Thank you all for investigation.
I confirmed Emilio's solution worked by injecting the style sheet via devtools on Android :)

Is it alright for me to implement the intervention?

to [:denschub]

It's unclear if you can actually finish a reservation or not. Let's triage this as workflow-broken for now, but if you can scroll down, it would just be a notable annoyance.

A reservation can be finished, so it's a notable annoyance.

And I wrote a site-patch and test. Could you please review it? If alright, I will submit the patch.

Flags: needinfo?(twisniewski) → needinfo?(dschubert)

Tom reviewed this, canceling my ni? Thanks for your work! :)

Flags: needinfo?(dschubert)
Pushed by twisniewski@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b892fb0096ff https://hg.mozilla.org/integration/autoland/rev/efe94df2bc2e add a CSS webcompat intervention for tjoy.jp zoom-in on Android. r=webcompat-reviewers,twisniewski

Was this canalun's patch that got landed? Maybe the author got clobbered when it was rebased?

Flags: needinfo?(twisniewski)

Ouch, yes, it might have been because I had to rebase the patch to my stack, to spare canalun the effort. Apologies, I fully intend to give canalun the credit here! (It seems weird that I reviewed my own patch, after all).

Flags: needinfo?(twisniewski)

Thanks, that's understandable. Not sure if we normally do a backout and relanding for an incorrect author like we do for an incorrect bug number.

Thank you, Thomas and Brian. I'd really appreciate it if we could correct the author info if possible :)
If there is anything I can do to help, please let me know.

Sounds like all we can do is back it out, and let canalun land it himself. I've asked for the patch to be backed out so canalun can alter it to add a version number, and re-land it when he's back.

Pushed by chorotan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/82aef685daed https://hg.mozilla.org/integration/autoland/rev/5789225ad678 Revert "Bug 2003826 - add a CSS webcompat intervention for tjoy.jp zoom-in on Android. r=webcompat-reviewers,twisniewski" on request

:canalun, I'm afraid I'll have to ask you to rebase your patch once the rest of my stack lands, as it will need to bump the version number of the addon's manifest (which ought to be 148.2.0 after my stack lands, and you can bump it to 148.3.0 and land your final patch).

Sorry for the mix-up!

Flags: needinfo?(i.am.kanaru.sato)

I mean, lando preserves committer information so another option is to just pull the patch, git amend it with the right author info, and re-land...

We still should bump the version number, or the addon might not be updated properly in the next nightly.

:twisniewski
no problem, thank you so much for reverting the patch :)
I got it. I'd appreciate it if you could kindly let me know when your stack lands and everything gets ready.

Flags: needinfo?(i.am.kanaru.sato)

The rest of the stack has landed, so feel free to rebase and bump to 148.3.0 and re-land yours :)

:twisniewski

Thanks! I bumped the version to 148.3.0 and the author has been successfully changed.
But I noticed I don't have the permission to land the patch.
So, could you please kindly land it when you have time?

Flags: needinfo?(twisniewski)

Yes, I'll land it for you, thanks again!

Flags: needinfo?(twisniewski)
Pushed by twisniewski@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2e492c742b3e https://hg.mozilla.org/integration/autoland/rev/b8ec3c843569 add a CSS webcompat intervention for tjoy.jp zoom-in on Android. r=webcompat-reviewers,twisniewski
User Story: (updated)
Webcompat Score: 8 → 1
Webcompat Priority: P1 → P3

I confirmed this has been fixed on Firefox Android 148 :)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: