2003830 - moz-select only visually looks disabled in Translations Settings

Status: ASSIGNED

(Toolkit :: UI Widgets, defect)

Description

[Erik Nordin [:nordzilla]]

Attachment: regression-example.mp4

Description

This is a bit of a strange regression to file, because it is for Bug 2002127, which I am still actively working on, but I noticed this issue come up in my latest rebase after Bug 1998560 landed.

I've attached a video of the issue. My moz-select in the Translations Settings subpage now visually looks disabled, even though it is functional. The moz-button next to it truly is disabled, until a valid option is selected.

---

I noticed that the following fixes it, but I don't know if it's the right fix.

diff --git a/toolkit/content/widgets/moz-select/moz-select.css b/toolkit/content/widgets/moz-select/moz-select.css
index ac7a2a9cb9d9..76ff1e27efbf 100644
--- a/toolkit/content/widgets/moz-select/moz-select.css
+++ b/toolkit/content/widgets/moz-select/moz-select.css
@@ -48,7 +48,7 @@
     color: var(--select-text-color-hover);
   }
 
-  &:has(:disabled) {
+  &:has(> :disabled) {
     border-color: var(--select-border-color-disabled);
     background-color: var(--select-background-color-disabled);
     color: var(--select-text-color-disabled);

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1998560

:hjones, since you are the author of the regressor, bug 1998560, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Hanna Jones [:hjones]]

Thanks for filing! I think your fix is spot on - I wasn't taking disabled options into account. Just put up a patch with the fix!

Comment 3

[Hanna Jones [:hjones]]

Thanks for filing! I think your fix is spot on - I wasn't taking disabled options into account. Just put up a patch with the fix!

Comment 4

[Hanna Jones [:hjones]]

Attachment: Bug 2003830 - fix moz-select looking disabled when an option is disabled r=#recomp-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2be192de165d
https://hg.mozilla.org/integration/autoland/rev/e2c9f606dd42
fix moz-select looking disabled when an option is disabled r=mkennedy