2003885 - Diagnose craches at CacheFileChunkBuffer

Status: ASSIGNED

(Core :: Networking: Cache, task, P2)

Description

[Thinker Li [:sinker]]

CacheFileChunkBuffer::DataSize() crashes for a reason unknown yet. CacheFileIOManager has been checked many times, but nothing found.
I wonder CacheFileChunk::OnDataRead() have been called twice, or mReadingStateBuf was not set properly. It is very difficult to reproduce. I am going to use MOZ_DIAGNOSTIC_ASSERT() to check if mReadingStateBuf and other fields set properly, and clean mCallback of ReadEvent to catch when calling OnDataRead() twice.

For both cases, they are going to crash definitely. So the changes here will not cause more damages.

Comment 1

[Thinker Li [:sinker]]

Attachment: Bug 2003885 - Diagnose crashes at CacheFileChunkBuffer.

CacheFileChunkBuffer::DataSize() crashes for a reason unknown
yet. This patch uses MOZ_DIAGNOSTIC_ASSERT() to check if
mReadingStateBuf and other fields set properly, and clear mCallback of
ReadEvent to catch when calling OnDataRead() twice.

For both cases, they are going to crash definitely. So the changes
here will not cause more damages.