2003898 - Hide the "Connect another device" button when user doesn't have sync keys

Status: ASSIGNED

(Firefox :: Firefox Accounts, defect)

Description

[Sammy Khamis [:skhamis]]

The "Connect another device..." button in the avatar menu needs sync keys to hand-off to your mobile device to connect it to your account. Now that no password/third-party authentication is a valid state for users, we should hide the button (for now) until they create a password for their account.

Comment 1

[Sammy Khamis [:skhamis]]

Attachment: Bug 2003898 - Dont show connect another device button if no sync keys r=#sync-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8edaac307780
https://hg.mozilla.org/integration/autoland/rev/31bb82920f88
Dont show connect another device button if no sync keys r=sync-reviewers,LougeniaBailey,markh

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f6db3d1b9180
https://hg.mozilla.org/integration/autoland/rev/faf146efb3e4
Revert "Bug 2003898 - Dont show connect another device button if no sync keys r=sync-reviewers,LougeniaBailey,markh" for causing failures at test_uistate.js.

Comment 4

[Atila Butkovits]

Backed out for causing failures at test_uistate.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/faf146efb3e4db7acb5ea178a8787f577055a480

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=31bb82920f88854ba8f65f076688de500bd840a8&selectedTaskRun=c1u6ZJfARESZQmn0wbNdlg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=538481304&repo=autoland&task=c1u6ZJfARESZQmn0wbNdlg.0&lineNumber=2396