2004060 - Sometimes comment is posted twice due to mid-air collision for non editbugs users

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Bug Creation/Editing, defect, P1)

Description

[Kohei Yoshino [:kohei]]

People have realized that sending a comment is now faster since Bug 1993761 was landed. However, in some cases, a comment is posted twice.

On Matrix, :wsmwk gave some examples:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1999025#c3 and c4
• https://bugzilla.mozilla.org/show_bug.cgi?id=1999025#c5 and c6
• https://bugzilla.mozilla.org/show_bug.cgi?id=1993760#c2 and c3
• https://bugzilla.mozilla.org/show_bug.cgi?id=2003713#c2 and c3

Comment 1

[David Lawrence [:dkl]]

Attachment: image.png

The comments were .56 seconds from each other

Comment 2

[Kohei Yoshino [:kohei]]

All of these duplicate comments were posted more than 15 seconds apart. One is 2 minutes, which is puzzling.

• Bug 1999025
  • c3 2025-12-03T19:28:21Z / c4 2025-12-03T19:29:08Z
  • c5 2025-12-03T19:31:02Z / c6 2025-12-03T19:31:58Z
• Bug 1993760
  • c2 2025-12-03T23:26:11Z / c3 2025-12-03T23:28:11Z
• Bug 2003713
  • c2 2025-12-04T03:36:49Z / c3 2025-12-04T03:37:07Z

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: Mid-air collision detected

I could repro this

Comment 4

[Kohei Yoshino [:kohei]]

If the user is not allowed to edit comments, there will be an exception, which is caught and triggers a from submission, even after a comment is posted successfully via API.

TypeError: can't access property "activate", Bugzilla.InlineCommentEditor is undefined

Comment 5

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Comment 6

[BMO Github Automation]

Authored by https://github.com/kyoshino
https://github.com/mozilla-bteam/bmo/commit/4ccd5975790f3063b871b3129a7d3bcdb33a5495
[master] Bug 2004060 - Sometimes comment is posted twice due to mid-air collision for non editbugs users