2004170 - Flip logic in AnchorResolvedSizeHelper::FromUnresolved

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Daniel Holbert [:dholbert]]

Filing this bug for a minor tweak to AnchorResolvedSizeHelper::FromUnresolved to make it easier to extend in bug 2000035 (to handle other keywords, namely stretch and friends).

The idea is to handle special cases (anchor positioning function, and soon stretch & aliases) in their own early-returns, and then handle the general case in a final return statement.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 2004170: Flip the logic ordering in AnchorResolved{...}Helper::FromUnresolved() methods. r?dshin,#layout

This doesn't change behavior at all; it just makes this function easier to
extend in the future.

Comment 2

[Daniel Holbert [:dholbert]]

Landing during the soft code-freeze given that there's no behavior-change (so, minimal risk); and taking this patch in v147 now will make patch-uplifting easier in surrounding code over the next 4 weeks (e.g. to fix late-breaking anchor positioning bugs).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b3002681350a
https://hg.mozilla.org/integration/autoland/rev/50adae86b20a
Flip the logic ordering in AnchorResolved{...}Helper::FromUnresolved() methods. r=TYLin

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/50adae86b20a