Closed Bug 20043 Opened 21 years ago Closed 20 years ago

addFile() returns bogus -1 when installing older version

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

All
Other
defect

Tracking

(Not tracked)

VERIFIED DUPLICATE of bug 22341

People

(Reporter: dveditz, Assigned: dveditz)

Details

Both addFile() and addDirectory() return version compare values -4, .. -1 when
the script tries to install a file with an older version than an existing file
and the force flag is not set.

It is correct that the older file is not installed, but it should not be
reported as an error to the script.
Assignee: cathleen → dveditz
Target Milestone: M12
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You can now attempt to install an older component and it will correctly be
skipped rather than return a bogus error.
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine
Blocks: 21564
QA Contact: jimmylee → depstein
Reassigning QA Contact to David.
Status: RESOLVED → REOPENED
not fixed. retested on build 2000011008-M13 (linux, nt and mac). returns -208
(invalid parameter) in logfile:
** ERROR (-208): Skipping: (null)

Install script aborted.
steps:
1) from http://jimbob/trigger2.html, select f_addsubcomp from dropdown. press
trigger case. This installs version 1.0.1.1 in reg package f_addsubcomp.
2) then select f_addsubcomp_vi_no_update from dropdown. Script has older version
(1.0.0.0) w/ force flag = false.
Note: In 4 separate tests, I tested lower major, minor, version and build
components of the version string, and in each case, it returns -208. (in each
case, the .xpi included an earlier test file and it correctly did not install
it).

Also, I tested compareVersion forms of InstallTrigger object and they were
returning expected values for each case.
Status: REOPENED → RESOLVED
Closed: 21 years ago20 years ago
Resolution: FIXED → DUPLICATE
*** This bug has been marked as a duplicate of 22341 ***
dup. 22341 has been fixed.
Status: RESOLVED → VERIFIED
No longer blocks: 21564
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.