Cleanup the macOS section of ipc/app/Makefile.in
Categories
(Firefox Build System :: General, task)
Tracking
(Not tracked)
People
(Reporter: yannis, Unassigned)
Details
(Keywords: good-first-bug)
Attachments
(2 external files)
On macOS, some of our child processes run dedicated executables that are copies of the Firefox executable signed with different entitlements. Part of this is achieved through ipc/app/Makefile.in, in a macOS-only section. The commands look like below:
# plugin-container
$(NSINSTALL) -D $(DIST)/bin/$(PROGRAM).app
rsync -a -C --exclude '*.in' $(srcdir)/macbuild/Contents $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app
$(call py_action,preprocessor $(MOZ_CHILD_PROCESS_NAME).app/Contents/Info.plist,-Fsubstitution -DEXECUTABLE='$(MOZ_CHILD_PROCESS_NAME)' -DBUNDLEID='$(MOZ_CHILD_PROCESS_BUNDLEID)' -DMOZ_DEVELOPER_REPO_PATH='$(topsrcdir)' -DMOZ_DEVELOPER_OBJ_PATH='$(topobjdir)' $(srcdir)/macbuild/Contents/Info.plist.in -o $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app/Contents/Info.plist)
$(call py_action,preprocessor $(MOZ_CHILD_PROCESS_NAME).app/Contents/Resources/English.lproj/InfoPlist.strings,-Fsubstitution --output-encoding utf-16 -DAPP_NAME='$(MOZ_CHILD_PROCESS_APPNAME)' $(srcdir)/macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in -o $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app/Contents/Resources/English.lproj/InfoPlist.strings)
$(NSINSTALL) -D $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app/Contents/MacOS
$(NSINSTALL) $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME) $(DIST)/bin/$(MOZ_CHILD_PROCESS_NAME).app/Contents/MacOS
Currently when adding a new dedicated executable, we would copy-paste and manually adapt this set of commands. We could refactor this file to avoid such duplication.
Comment 1•11 months ago
|
||
I am new to open source contributions and would like to work on this bug.
I have set up the Firefox build environment and will start investigating
ipc/app/Makefile.in to refactor the macOS section as described.
Comment 2•11 months ago
|
||
Updated•11 months ago
|
Updated•11 months ago
|
Comment 3•10 months ago
|
||
Updated•10 months ago
|
Comment 4•8 months ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.
Comment 5•8 months ago
|
||
Hello, I would like to give it a try!
Description
•